Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconToggle: componentWillReceiveProps() deprecated #471

Open
mzu opened this issue Apr 12, 2020 · 4 comments
Open

IconToggle: componentWillReceiveProps() deprecated #471

mzu opened this issue Apr 12, 2020 · 4 comments

Comments

@mzu
Copy link

mzu commented Apr 12, 2020

Thought I should let you know:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

  • Move data fetching code or side effects to componentDidUpdate.
  • If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
  • Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: IconToggle

@areebvohra
Copy link

i am also having the same problem with componentWillReceiveProps lifecycle when will this be solved?

@fmsthird
Copy link

fmsthird commented Sep 2, 2020

any update on this? @mzu @areebvohra , were you guys able to solve this?

@mzu
Copy link
Author

mzu commented Sep 4, 2020

any update on this? @mzu @areebvohra , were you guys able to solve this?

@fmsthird I am not using this anymore, so I don't really know if this has been sorted or not.

@fmsthird
Copy link

fmsthird commented Sep 4, 2020

Thanks for your response @mzu , I managed to fix it myself. I forked the repo and run npx react-codemod rename-unsafe-lifecycles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants