-
-
Notifications
You must be signed in to change notification settings - Fork 292
Commit
babel-eslint
ESLint now supports ES2017 \o/ This will be a breaking change if you used things like decorators or Flow syntax.
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,4 @@ | ||
'use strict'; | ||
module.exports = { | ||
// always use the Babel parser so it won't throw | ||
// on esnext features in normal mode | ||
parser: 'babel-eslint', | ||
plugins: ['babel'], | ||
rules: { | ||
'generator-star-spacing': 0, | ||
'new-cap': 0, | ||
'array-bracket-spacing': 0, | ||
'object-curly-spacing': 0, | ||
'arrow-parens': 0, | ||
'babel/generator-star-spacing': [2, 'both'], | ||
'babel/new-cap': [2, { | ||
newIsCap: true, | ||
capIsNew: true | ||
}], | ||
'babel/array-bracket-spacing': [2, 'never'], | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
sindresorhus
Author
Member
|
||
'babel/object-curly-spacing': [2, 'never'], | ||
'babel/arrow-parens': [2, 'as-needed'] | ||
} | ||
// put rule overrides here | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
'use strict'; | ||
module.exports = { | ||
rules: { | ||
'babel/object-curly-spacing': 0 | ||
'object-curly-spacing': 0 | ||
} | ||
}; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
4 comments
on commit 04733f1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if I understand this correctly, if you're using stage-2 or stage-1 things, this will break linting? Isn't this very breaking? Is there an option to keep using babel-eslint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is breaking, yes. I'm pretty sure you can install babel-eslint yourself and specify the parser to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the point of XO making the use ESLint easier by providing things like "space" and "semicolon"? I would expect a setting like "babel"… I'm not even sure XO lets you override the parser…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wmertens I only used babel-eslint
to get async functions. Now that it's part of ESLint, I see no point in having the overhead. babel-eslint
was a nightmare to maintain. It was constantly buggy, slower, blocked upgrading to latest ESLint many times, not very actively maintained. Should be easy to add a parser
option. Open an issue/PR if you need it.
Are you sure this one can be removed?