Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto_increment ordering breaks parse, no error returned #163

Closed
earonesty opened this issue Oct 27, 2022 · 3 comments
Closed

auto_increment ordering breaks parse, no error returned #163

earonesty opened this issue Oct 27, 2022 · 3 comments
Assignees

Comments

@earonesty
Copy link

earonesty commented Oct 27, 2022

the following results in "None", no errors

create table "foo" ("auto" integer not null primary key auto_increment,"inty" integer not null default(4),"blob" blob,"blob3" binary(3),"blob4" varbinary(4),"tex" text not null,"siz3v" varchar(3),"siz3" character(3),"flt" float default(1.1),"dbl" double default(2.2));

if i knew a bit more about how the yacc module worked, i would fix it, looking at it now

looks like the mysql auto_increment breaks it, even though this executes correctly in mysql

@earonesty earonesty changed the title Valid ANSI sql not parsed auto_increment ordering breaks parse, no error returned Oct 27, 2022
@xnuinside
Copy link
Owner

@earonesty thanks for reporting it, honestly it is a second issue about increment & I already started work on fix for that but didn’t finished yet. I have some time on Sunday - will try to work on it

@xnuinside
Copy link
Owner

@earonesty in your ddl also one more interesting issue! my parser totally unsupport floats :) will fix it, thanks one more time!

@xnuinside xnuinside self-assigned this Oct 30, 2022
@xnuinside
Copy link
Owner

@earonesty I just released version 0.28.0 https://pypi.org/project/simple-ddl-parser/, both issues was fixed, I also added test for your sample: https://github.com/xnuinside/simple-ddl-parser/blob/main/tests/test_simple_ddl_parser.py#L2791

If will be needed anything else - feel free to open new issue. And thanks one more time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants