Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTER Constraint UNIQUE must be showed in column also #101

Closed
xnuinside opened this issue Nov 28, 2021 · 2 comments
Closed

ALTER Constraint UNIQUE must be showed in column also #101

xnuinside opened this issue Nov 28, 2021 · 2 comments
Labels
bug Something isn't working improvement

Comments

@xnuinside
Copy link
Owner

Issue was reported here: #99

This is a big help. It parses without throwing an exception now! I think there's still room for improvement in understanding the meaning of the Postgres schema. For example, the DDL contains

ALTER TABLE ONLY public.accounts ADD CONSTRAINT accounts_username_key UNIQUE (username);

But in the parsed output, we see:

{'name': 'username',
'type': 'character varying',
'size': 50,
'references': None,
'unique': False, <======= should be True?
'nullable': False,
'default': None,
'check': None},
But the bug I reported is fixed, so closing this issue.

@xnuinside
Copy link
Owner Author

problem was in ALTER TABLE ONLY (only was not supported)

@xnuinside
Copy link
Owner Author

fixed in 0.23.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement
Projects
None yet
Development

No branches or pull requests

1 participant