Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL decode filenames for Remote attachments #105

Closed
nplasterer opened this issue Sep 12, 2023 · 0 comments · Fixed by #114
Closed

URL decode filenames for Remote attachments #105

nplasterer opened this issue Sep 12, 2023 · 0 comments · Fixed by #114
Assignees
@nplasterer
Labels
bug Something isn't working

Comments

@nplasterer
Copy link
Contributor

We are using a random path to save file but then I think we should send back the
decrypted filename in the DecryptedLocalAttachment. so you can use it to show the name to the user.
Filename can also be in the RemoteAttachmentMetadata but it’s not mandatory so if it’s been decrypted later it’s nice to be able to use it
@nplasterer nplasterer added the bug Something isn't working label Sep 12, 2023
@nplasterer nplasterer self-assigned this Sep 13, 2023
@nplasterer nplasterer mentioned this issue Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nplasterer nplasterer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add file name to decrypted local attachment xmtp/xmtp-react-native
1 participant
@nplasterer