Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2/V1 Removal #697

Closed
4 tasks
Tracked by #693
nplasterer opened this issue May 1, 2024 · 0 comments
Closed
4 tasks
Tracked by #693

V2/V1 Removal #697

nplasterer opened this issue May 1, 2024 · 0 comments

Comments

@nplasterer
Copy link
Contributor

nplasterer commented May 1, 2024

One time migration

In order to fully deprecate V2, we are going to need to do a one-time read of all your existing V2 conversations and dump them in to the libxmtp database.

One question we’ll need to answer as part of that process is whether we want to import messages where the other party has not yet setup a V3 identity. That would mean you would have messages in a conversation that are read-only, since there is no way to send new V3 messages to them. If the other party later sets up the V3 identity, we’d want some way for the message to become part of your V3 1:1 conversation with the user.

The advantage of doing it in advance of the other person migrating to V3 is that we can do the migration all at once and kill V2 earlier. The disadvantage is that we have to deal with these read-only convos, which can be complicated for devs. Maybe it’s not so bad because they’d be treated the same as a group that you were no longer a member of.

Need to think through the details here. When do we want to trigger this migration? Can we do it lazily?

  • Period of read only
  • Clear datadog metric tracking
  • Import of all V2 messages into V3 database
    • Dedupe on message unique identifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants