Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions - Ability to create a group chat that only has two members and cannot have additional members added (Medium) #694

Closed
6 tasks
nplasterer opened this issue May 1, 2024 · 1 comment
Assignees

Comments

@nplasterer
Copy link
Contributor

nplasterer commented May 1, 2024

1:1 chats don’t need custom permissions IMO. All 1:1 chats should work the same way.

We should be able to use our existing permissions framework to enable 1:1. We’d just define a default permission set required on all 1:1 chats.

We may want to spend a bit of time making sure we don’t need to upgrade our permission system to support this permission set. Maybe there are some additional fields we can add now, even if they’re unused, to make room for 1:1. For example, an optional list of allowed_members on the ImmutableMetadata to restrict the group to 2 people.

  • New permission type to identify a 1to1 conversations
  • Way to handle adding just one person to the group after create (possibly and immutable list called allowed_members)
  • Validation
    • 1to1 Group should not be able to be named
    • You cannot leave a 1to1 Group
    • Should not see a group membership change codec on first send
@cameronvoell
Copy link
Contributor

Related PR - #901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants