Message failed state

[nplasterer]

          In the follow up PR we should do the following

1. Mark the optimistic message as FAILED whenever its intent is marked as failed (set_group_intent_error)
2. Make sure that every possible error case in this method results in the corresponding intent either being marked as TO_PUBLISH or FAILED
3. At some point in the future revisit whether there is a possibility of an infinite loop of intent retries. Maybe we should call increment_intent_publish_attempt_count() wherever we reset an intent to TO_PUBLISH, and just set a really high retry limit, like 10?

For (2), maybe the most fool-proof way is to mark all MessageProcessingErrors as either retryable or non-retryable, and have the caller of the method catch all errors and mark the intent as TO_PUBLISH for retryable errors and FAILED for non-retryable errors

Originally posted by @nplasterer in #669 (comment)