Fix XMonad.Prompt wraparound when maxComplRows not Nothing #217 #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgsloan
force-pushed
the
fix-prompt-max-rows-wrap-around-217
branch
from
1569395 to
d9f43c7
Compare
|
Ping! Any maintainer want to review this? I've rebased it atop master. |
|
Thanks for the PR and for the nudge! |
|
You're welcome, thanks for merging!
…On Tue, Feb 12, 2019, 07:08 Brent Yorgey ***@***.*** wrote:
Thanks for the PR and for the nudge!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#291 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABYKrYF7Pbvwx8aYZJ4KU0Ts9GcvMKGks5vMtj5gaJpZM4aQN4F>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When tabbing through the prompt list of completions, if the list of completions does not fit due to
maxComplRows, without this fix an exception would be thrown. I am not certain why, but this exception occurs due to a pattern mismatch at https://github.com/mgsloan/xmonad-contrib/blob/dda242a4597c1ed0fa895a10b9296dcc709f4937/XMonad/Prompt.hs#L919However, the root cause appears to be in the
nextComplIndexfunction. The problem is that it was assuming that dividing the total item count by the number of rows would yield the number of columns. This did not hold when the number of rows was being limited.Checklist
I've read CONTRIBUTING.md
I tested my changes with xmonad-testing
I updated the
CHANGES.mdfile