Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Votifier Protocol Version #37

Open
Iapetus-11 opened this issue Sep 12, 2022 · 1 comment
Open

Incorrect Votifier Protocol Version #37

Iapetus-11 opened this issue Sep 12, 2022 · 1 comment

Comments

@Iapetus-11
Copy link

It seems this software reports votifier version 2.9 which is incorrect. Since this software (seems to) support the Votifier V1 protocol, it may be a good idea to change the version to 1.

Relevant code seems to be here and I am happy to make a pull request if necessary.
@xmamo
Copy link
Owner

xmamo commented Dec 18, 2022

Thank you! You’re right, it is the wrong protocol version. I was thinking about it some time ago, but never made the change. I’ll do it ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xmamo @Iapetus-11