Git not found

[SirLynix]

Describe the bug

Some user reported a strange log where git was installed by xmake and used to clone xmake-repo but failed to clone a dependency later.

I'm under the impression xmake runs git from where it found it when cloning repositories but when cloning a repository (like concurrentqueue) it tries to run git like if it was in the path (which it wasn't).

Rebooting fixed the issue, but as I found that strange I decided to report that.

Expected behavior

That xmake is able to always use git after installing it.

Error output

(Note, this is the second run, git was installed by xmake the first run).

djarkhaal@MACHINE:/mnt/e/FullCycleGames/BurgWar-master$ xmake.exe config --arch=x64 --mode=debug -v
checking for vswhere.exe ... C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe
checking for cl.exe ... C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29333\bin\Host
X64\x64\cl.exe
checking for Microsoft Visual Studio (x64) version ... 2019
checking for dmd ... no
checking for ldc2 ... no
checking for gdc ... no
checking for unzip ... no
checking for 7z ... ok
checking for git ... ok
checking for gzip ... no
checking for ping ... ok
checking for nmap ... no
pinging for the host(gitlab.com) ... 65535 ms
pinging for the host(github.com) ... 16 ms
pinging for the host(gitee.com) ... 201 ms
updating repositories ..
cloning repository(xmake-repo): https://github.com/xmake-io/xmake-repo.git to C:\Users\Max\AppData\Local\.xmake\reposito
ries\xmake-repo ..
git clone https://github.com/xmake-io/xmake-repo.git -b master C:\Users\Max\AppData\Local\.xmake\repositories\xmake-repo
Cloning into 'C:\Users\Max\AppData\Local\.xmake\repositories\xmake-repo'...
remote: Enumerating objects: 50, done.
remote: Counting objects: 100% (50/50), done.
remote: Compressing objects: 100% (24/24), done.
remote: Total 5712 (delta 25), reused 38 (delta 19), pack-reused 5662
Receiving objects: 100% (5712/5712), 961.07 KiB | 1.97 MiB/s, done.
Resolving deltas: 100% (2990/2990), done.
ok
checking for xmake::concurrentqueue ... no
checking for vcpkg ... no
checking for pkg-config ... no
checking for concurrentqueue ... no
checking for xmake::nlohmann_json ... no
checking for nlohmann_json ... no
checking for cmake ... no
checking for cmake ... no
checking for xmake::fmt ... no
checking for fmt ... no
checking for xmake::libcurl ... no
checking for libcurl ... no
checking for xmake::nazaraengine ... no
checking for nazaraengine ... no
checking for xmake::nazaraengine~server ... no
checking for nazaraengine~server ... no
checking for xmake::stackwalker ... no
checking for stackwalker ... no
note: try installing these packages (pass -y to skip confirm)?
in xmake-repo:
  -> concurrentqueue master
  -> nlohmann_json v3.9.1
  -> cmake 3.18.4
  -> fmt 7.1.3 (debug)
  -> libcurl 7.73.0 (debug)
  -> stackwalker 1.20
in burgwar-repo:
  -> nazaraengine 20201119 (debug)
  -> nazaraengine~server 20201119 (debug)
please input: y (y/n)
y
pinging for the host(curl.haxx.se) ... 65535 ms
pinging for the host(cmake.org) ... 85 ms
pinging for the host(curl.mirror.anstey.ca) ... 65535 ms
git clone https://github.com/cameron314/concurrentqueue.git -b master --depth 1 --recursive source.tmp\concurrentqueue
error: cannot execv(git clone https://github.com/cameron314/concurrentqueue.git -b master --depth 1 --recursive source.t
mp\concurrentqueue), No such file or directory
  => clone https://github.com/cameron314/concurrentqueue.git master .. failed

we can also download these packages manually:
  - https://github.com/cameron314/concurrentqueue.git
to the local search directories:
  - concurrentqueue.git
and we can run `xmake g --pkg_searchdirs=/xxx` to set the search directories.
error: ...mdir\core\sandbox\modules\import\core\base\scheduler.lua:47: download failed!
stack traceback:
        [C]: in function 'error'
        @programdir\core\base\os.lua:789: in function 'raise'
        ...mdir\core\sandbox\modules\import\core\base\scheduler.lua:47: in function 'co_start_named'
        @programdir\modules\private\async\runjobs.lua:180: in function <@programdir\modules\private\async\runjobs.lua:13
9>
        [C]: in function 'trycall'
        @programdir\core\base\scheduler.lua:423: in function 'co_group_begin'
        ...mdir\core\sandbox\modules\import\core\base\scheduler.lua:85: in function 'co_group_begin'
        @programdir\modules\private\async\runjobs.lua:139: in function 'runjobs'
        @programdir\actions\require\impl\package.lua:573: in function '_install_packages'
        @programdir\actions\require\impl\package.lua:826: in function 'install_packages'
        @programdir\actions\require\install.lua:191: in function 'install_requires'
        @programdir\actions\config\main.lua:297: in function <@programdir\actions\config\main.lua:163>
        [C]: in function 'load'
        @programdir\core\base\task.lua:520: in function 'run'
        @programdir\core\main.lua:282: in function 'cotask'
        @programdir\core\base\scheduler.lua:317: in function <@programdir\core\base\scheduler.lua:315>

Related Environment

• xmake version: xmake v2.3.9
• os: Windows 10
• target platform: Windows 10

[waruqi]

Ok, I will look at it.

[waruqi]

You can try to delete the %localappdata%/.xmake/repositories directory and re-run xmake to reproduce it.

And I have fixed it on dev branch now.

[SirLynix]

Thanks for the quick reply and fix, I asked him to try to reproduce the issue.

[waruqi]

Ok, It should work. I closed it first.