Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a regression test plan #273

Closed
tianyin opened this issue Oct 30, 2023 · 3 comments · Fixed by #294
Closed

Figure out a regression test plan #273

tianyin opened this issue Oct 30, 2023 · 3 comments · Fixed by #294
Assignees
Labels
bug Something isn't working high-pri high priority task that blocks the progress

Comments

@tianyin
Copy link
Member

tianyin commented Oct 30, 2023

It seems that the github tests are flaky and always timeout, and we are mostly relying on cloudlab tests?

@ThrivikramanV Could you figure out the right practice to do regression tests, given that we will have more folks working on the project like @MarkintoshZ ?

@tianyin tianyin added bug Something isn't working high-pri high priority task that blocks the progress labels Oct 30, 2023
@ThrivikramanV
Copy link
Collaborator

Sure, on this.

@tianyin
Copy link
Member Author

tianyin commented Oct 30, 2023

Thanks @ThrivikramanV ! It's great that we can resolve this long-lasting issue!

@tylergu
Copy link
Member

tylergu commented Nov 1, 2023

Let me use this issue to keep track of the planned actions so that we don't forget them

  • Have a Github action that randomly select one bug to reproduce. This action can run quickly, and is run for each PR. (Modified e2e regression tests to reproduce only one bug #275)

  • Have a weekly action to reproduce all bugs. For this, we need to recruit one idle lab machine to use as the Github self-hosted runner. I think PT2 and PT3 are mostly idle these days.

  • Better organize the unittests and e2e tests. We want to separate unittests and e2e tests, because we want separate github actions for them. There are two ways to go with this:

    • Putting unittests and e2e tests in separate directory, so that the github actions can just invoke pytest on different directories to separate unittest and e2e tests.
    • Using pytest marker to annotate each test, and the github action invokes the tests using the markers.

    The first option is probably better, and we are already in a good shape for that (our unittests are in the source code directories, and e2e tests are in the test directory)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-pri high priority task that blocks the progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants