refactor: default to Qt Multimedia and delete default player shenanigans #1994
Conversation
|
I think for now, Just inform the users the ffmpeg should be blamed. no need to build the source code. |
|
In a fresh startup, the audioPlayer fallback to the default one. Open and close GD → in config, the audioPlayer will be empty. In the next startup, GD-ng will fall back to the default one. Don't really care how the original GD will behave. Hopefully, the defensive programming of that person can handle this situation. |
| if ( !playerPtr || !qobject_cast< MultimediaAudioPlayer * >( playerPtr.data() ) ) { | ||
| playerPtr.reset( new MultimediaAudioPlayer ); | ||
| } | ||
| playerPtr.reset( internalPlayerBackend.getActualPlayer() ); |
There was a problem hiding this comment.
reset will delete the current one and take over the ownership of incoming pointer.
Ok. |
Slightly related to #1738
Because on Linux, qt multimedia can uses the
GStreamerwhich uses libspeex and it is not broken.We currently don't ship FFmpeg backend for Windows & macOS.
If #1738 is not fixable, we can also consider reinstate the FFmpeg backend and build FFmpeg by ourselves.
Changing default back is as simple as changing the order of
availableBackends()