Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS-EGNN doesn't work smoothly with PyG 2.5 #93

Open
xiaoruiDong opened this issue Mar 28, 2024 · 0 comments
Open

TS-EGNN doesn't work smoothly with PyG 2.5 #93

xiaoruiDong opened this issue Mar 28, 2024 · 0 comments

Comments

@xiaoruiDong
Copy link
Owner

Haven't figured out the reason yet. Potentially related to this issue.

TS-EGNN includes a modified version of EGNN implementation from https://github.com/lucidrains/egnn-pytorch. Even after incorporating the new changes of PyG (changing attribute names and so on) to the TS-EGNN code, TS-EGNN is still not working.

The error is raised at

hidden_out, coors_out = self.propagate(edge_index, x=feats, edge_attr=edge_attr_feats,
                                                           coors=coors, rel_coors=rel_coors, 
                                                           batch=batch)

# where the last step of propagate is 
return self.update((hidden_out, coors_out), **update_kwargs)

and the error implies the returned item is not a tuple.

But very weirdly, when I inserted a pdb.set_trace() inside the propagate and simply "continue"d it after stopping, everything worked. The same script also works on PyG 2.4.0 without issues. Inspired by the issue above, it makes me wonder if this relates to dynamic compilation or something similar, especially given propagate is re-implemented in the egnn code. However, no further action is planned at the moment

Current solution: use PyTorch 2.1.2 + PyG 2.4.0 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant