Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed genDisplayName method to use reg-ex that works on iOS Safari … #3816

Closed
wants to merge 2 commits into from

Conversation

cnrudd
Copy link
Member

@cnrudd cnrudd commented Oct 21, 2024

…16 (used by BB Access)

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@cnrudd
Copy link
Member Author

cnrudd commented Oct 21, 2024

After more digging, I think that the regex that I changed is probably not the cause of the error on the clients device.
There is probably an offending regex in some library code. We are going to ask the client to make sure he is on ios18 before digging further.

@cnrudd
Copy link
Member Author

cnrudd commented Oct 21, 2024

Source of issue was found in GFM support, brought in to framework in v65.0.0.
The offending reg ex is in this lib:
https://github.com/syntax-tree/mdast-util-gfm-autolink-literal
See their issue: syntax-tree/mdast-util-gfm-autolink-literal#10

Closing PR without merging - @amcclain already put the fontawesome fix into develop.

@cnrudd cnrudd closed this Oct 21, 2024
@lbwexler lbwexler deleted the bb-regex-hotfix branch October 28, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant