Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.6 #40

Merged
merged 5 commits into from
Apr 5, 2021
Merged

Drop Python 3.6 #40

merged 5 commits into from
Apr 5, 2021

Conversation

jrbourbeau
Copy link
Contributor

As xhistograms dependencies, i.e. numpy, dask, and xarray, have all dropped support for Python 3.6, it probably makes sense for us to drop support here too.

@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #40 (9e5434b) into master (2b2b82e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files           3        3           
  Lines         215      215           
  Branches       58       58           
=======================================
  Hits          203      203           
  Misses          8        8           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b2b82e...9e5434b. Read the comment docs.

Copy link
Contributor

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed and thanks @jrbourbeau. Any idea why we're now regularly failing test_histogram_results_1d in a number of active PRs (#38 also)? I'm happy to try look into this if nothing springs to mind.

@jrbourbeau
Copy link
Contributor Author

Great, thanks for reviewing @dougiesquire! I've proposed a quick fix for test_histogram_results_1d over in #41

@jrbourbeau
Copy link
Contributor Author

Just included the quickfix from #41 here -- so CI is passing now. If we're comfortable dropping Python 3.6, then I think this PR should be good to go

@dougiesquire dougiesquire merged commit 40b6f3a into xgcm:master Apr 5, 2021
@jrbourbeau jrbourbeau deleted the drop-py36 branch April 6, 2021 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants