Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why Latte Model can‘t support PipeFusion #225

Open
philipwan opened this issue Aug 26, 2024 · 3 comments
Open

Why Latte Model can‘t support PipeFusion #225

philipwan opened this issue Aug 26, 2024 · 3 comments

Comments

@philipwan
Copy link

Open-Sora-v1.1’s Transformer module come from Latte, I see PipeFusion doesn't support Latte in README.
How does xDit support Open-Sora-v1.1/1.2 module, any suggestions ?

Thank you~

@feifeibear
Copy link
Collaborator

feifeibear commented Aug 26, 2024

We just have no time to support pipefuson on Latte.
Currently, we are focusing on CogVideoX, which seems more popular right now.
I found ColossalAI, the framework developed by the company behind Open-Sora, has already used pipefusion.

https://github.com/hpcaitech/ColossalAI/blob/7cf9df07bcb267c0839d8880b109c4c7d55e80fa/colossalai/inference/modeling/layers/distrifusion.py#L3

Would like to help us on supporting PipeFusion for Latte-based models?

@philipwan
Copy link
Author

We just have no time to support pipefuson on Latte. Currently, we are focusing on CogVideoX, which seems more popular right now. I found ColossalAI, the framework developed by the company behind Open-Sora, has already used pipefusion.

https://github.com/hpcaitech/ColossalAI/blob/7cf9df07bcb267c0839d8880b109c4c7d55e80fa/colossalai/inference/modeling/layers/distrifusion.py#L3

Would like to help us on supporting PipeFusion for Latte-based models?

Sorry for my mistake, I want to support for open-sora-plan v1.2 which has same struction with CogVideoX. Open-Sora may be slightly worse video quality, but ColossalAI's PipeFusion is a good example. I will try to keep following up.

@feifeibear
Copy link
Collaborator

We just have no time to support pipefuson on Latte. Currently, we are focusing on CogVideoX, which seems more popular right now. I found ColossalAI, the framework developed by the company behind Open-Sora, has already used pipefusion.
https://github.com/hpcaitech/ColossalAI/blob/7cf9df07bcb267c0839d8880b109c4c7d55e80fa/colossalai/inference/modeling/layers/distrifusion.py#L3
Would like to help us on supporting PipeFusion for Latte-based models?

Sorry for my mistake, I want to support for open-sora-plan v1.2 which has same struction with CogVideoX. Open-Sora may be slightly worse video quality, but ColossalAI's PipeFusion is a good example. I will try to keep following up.

We can work together on open-sora-plan v1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants