Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"impression_count" is missing #61

Open
sor4chi opened this issue Jan 8, 2023 · 5 comments
Open

"impression_count" is missing #61

sor4chi opened this issue Jan 8, 2023 · 5 comments

Comments

@sor4chi
Copy link

sor4chi commented Jan 8, 2023

Twitter has recently started publishing impression counts, so the API can now also take impression_count in public_metrics. On the other hand, you can no longer get impression_count from non_public_metrics.

Expected behavior

CAN to get impression_counts from public_metrics
CANNOT to get impression_counts from non_public_metrics

Actual behavior

CANNOT to get impression_counts from public_metrics
CAN to get impression_counts from non_public_metrics

Steps to reproduce the behavior

please use this
https://github.com/sor4chi/repro-twitter-sdk-missing-params

@sor4chi
Copy link
Author

sor4chi commented Jan 8, 2023

Sorry, it looks like you just haven't generated the latest one.
#51
Merging and generating this would solve the problem.

@sboy99
Copy link

sboy99 commented Jul 5, 2023

Has it been fixed

@sboy99
Copy link

sboy99 commented Jul 5, 2023

Screenshot from 2023-07-05 11-37-30
Screenshot from 2023-07-05 11-36-22

@sor4chi
Copy link
Author

sor4chi commented Jul 10, 2023

@sboy99
I don't think it has been fixed yet. The repository itself doesn't seem to be maintained in the first place. Probably since Elon fired some employees.

@sor4chi
Copy link
Author

sor4chi commented Jul 10, 2023

If you want to use it, you can fork it yourself, import #51, and publish it to your npm scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants