-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinning openssl to fix failing unittest on mac #578
Pinning openssl to fix failing unittest on mac #578
Conversation
Docker builds failing due to open PR: #575 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to check, whether this has implications on the cluster deployments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, had to revoke my approval. Unittests fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove the whole line.I don't think that flask-testing and requests-mock is actually beebn used in xcube ubnittests
@@ -31,7 +31,7 @@ jobs: | |||
shell: bash -l {0} | |||
run: | | |||
pip install pytest pytest-cov | |||
mamba install -c conda-forge flask-testing moto requests-mock | |||
mamba install -c conda-forge flask-testing requests-mock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mamba install -c conda-forge flask-testing requests-mock |
[Description of PR]
This PR only adds openssl to the dependencies of xcube, and pins it to the last working version. This should be undone, once conda/conda#11111 is solved.
No code has changed.
FYI @forman @TonioF
Checklist:
Add unit tests and/or doctests in docstringsAdd docstrings and API docs for any new/modified user-facing classes and functionsNew/modified features documented indocs/source/*
Changes documented inCHANGES.md
Remember to close associated issues after merge!