Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning openssl to fix failing unittest on mac #578

Merged
merged 13 commits into from
Jan 7, 2022

Conversation

AliceBalfanz
Copy link
Contributor

@AliceBalfanz AliceBalfanz commented Jan 6, 2022

[Description of PR]
This PR only adds openssl to the dependencies of xcube, and pins it to the last working version. This should be undone, once conda/conda#11111 is solved.

No code has changed.

FYI @forman @TonioF

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

Remember to close associated issues after merge!

@AliceBalfanz AliceBalfanz requested review from pont-us and dzelge January 6, 2022 07:46
@AliceBalfanz
Copy link
Contributor Author

Docker builds failing due to open PR: #575

Copy link
Member

@pont-us pont-us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@dzelge dzelge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to check, whether this has implications on the cluster deployments.

@dzelge dzelge self-requested a review January 6, 2022 08:05
Copy link
Contributor

@dzelge dzelge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, had to revoke my approval. Unittests fail.

Copy link
Contributor

@dzelge dzelge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the whole line.I don't think that flask-testing and requests-mock is actually beebn used in xcube ubnittests

@@ -31,7 +31,7 @@ jobs:
shell: bash -l {0}
run: |
pip install pytest pytest-cov
mamba install -c conda-forge flask-testing moto requests-mock
mamba install -c conda-forge flask-testing requests-mock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mamba install -c conda-forge flask-testing requests-mock

@AliceBalfanz AliceBalfanz merged commit f333bce into master Jan 7, 2022
@AliceBalfanz AliceBalfanz deleted the alicja-xxx-investigate_failing_unittest_mac branch January 7, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants