Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions prior to 3.5 deleted from Nuget #1499

Closed
dgosbell opened this issue Jun 17, 2019 · 6 comments
Closed

Versions prior to 3.5 deleted from Nuget #1499

dgosbell opened this issue Jun 17, 2019 · 6 comments

Comments

@dgosbell
Copy link

Can the versions prior to 3.5 (specifically 3.3) please be restored back to the nuget feed?

I have some issue with Avalon Dock in 3.5 that I'm still trying to figure out (none of my anchorable windows are showing their views, just the name of their ViewModel) But now I can't build anything as when I tried to rollback my changes to use v3.3 of WPFToolkit it can no longer be dowloaded from nuget and it's not available on the GitHub releases either.

Please help as I'm trying to do some bug fixes on the current release for my project, but I can no longer build these due to version 3.3 being missing in nuget.

@Dirkster99
Copy link

Hi,

the nugets are not deleted but only removed from listing. For debugging, you can still go back in time to version 3.3 or 3.4 by compiling the libraries from source instead of using NuGet.

For AvalonDock 3.5, please check my branch as it seems to have solved most critical problems 3.5.

@dgosbell
Copy link
Author

Yes, sorry it appears to have been some intermittent issue. I've tried again and nuget does return the 3.3 release even though it's not listed. And I've also figured out my issue with 3.5. It appears that the following line was changed

Content="{Binding LayoutItem.View.Content, RelativeSource={RelativeSource TemplatedParent}}" />

Which used to look like this (without the .Content on the Binding path)

Content="{Binding LayoutItem.View, RelativeSource={RelativeSource TemplatedParent}}" />

I'm using Caliburn.Micro as an MVVM framework and I've worked around this issue by adding the old theme back via a style in my project.

@Dirkster99
Copy link

Yes, I remember that one. Please be aware that you will run into more such problems as you use the open source version of AvalonDock 3.5. The list of issues we've found and fixed so far can be seen here

  • Your issue was fixed at version 3.5.2 see 'Fixed Issue about PanesTemplateSelector being ignored'

I would strongly suggest to use the nuget from my branch unless you want to run into each of the problems listed and fix them on your own in your private branch...

@dgosbell
Copy link
Author

Thanks @Dirkster99 I've switched my project over to use your branch which has let me delete that extra style that I don't really need. I really only need AvalonDock so this will also trim down my dependencies a bit.

PS. Thanks for publishing your articles on how you implemented AvalonDock in EDI it was really helpful to me in getting it to work with my project DAX Studio I'm just browsing through some of your other projects as I would like to implement a dark them option and it looks like some of your stuff might be useful there.

@Dirkster99
Copy link

Thats great to know - your DB app looks really cool :-) just spread the word and be sure to assign a ⭐️ where it helps you so others find these projects more easily...

@Dirkster99
Copy link

This project should be the most useful starting point if you look at theming (because you will find out that Dark themes will also make Light Highlighting definitions look aweful):
https://github.com/Dirkster99/AvalonEditHighlightingThemes

Therefore, I've extended the normal HighlightingManager in AvaloneEdit, implemented a ThemeableHighlightingManager and connected it with ThemesManager I am using for WPF. Now, all all aspected of colorization can be setup to work consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants