kodi-addon-checker.log (Found non whitelisted file ending in filename) reported on PR test

[anxdpanic]

Started integrating TravisCI/addon-check into some repositories, currently quite a few false problems/warnings.
It looks like the .git folder is ignored in master(which would resolve most false reports), but I don't see anything addressing the log file in master.
See: https://travis-ci.org/jdf76/plugin.video.youtube/jobs/485145419#L520

[razzeee]

Jep, needs to be ignored by the full name I guess.

Still fells like we need more then --PR and not setting that.
As far as I know we have at least three cases:

• Running against a repo
• Running as PR (one addon folder)
• Running it not as a PR against your folder

Might be nicer if we can change that commandline option.
And the things we need to change for the last case should only be removing git from the scan.

See #123 for the other problem.

[anxdpanic]

Noticed a couple other ERROR reports, that could probably be INFO for single addon folder PR

ERROR: Addon id and folder name does not match. (eg. Twitch-on-Kodi/plex-for-kodi)
and
ERROR: plugin.video.twitch addon already exists with version: 2.4.1 in isengard branch

https://travis-ci.com/MrSprigster/Twitch-on-Kodi/builds/98843745#L502 (Line 503 and 504)

[Rechi]

ERROR: plugin.video.twitch addon already exists with version: 2.4.1 in isengard branch

That's exactly the use case of the --PR command line argument. It's not expected that you run your checks always with --PR. It's only for our repos to check that the version is actually increased in a PR.

[anxdpanic]

Okay, so --PR shouldn't be used on PR's outside of the official repo?
I'm using it on PR's like in the above log, based on the argument description and https://github.com/xbmc/addon-check/blob/master/.travis-addon.yml.example

[Rechi]

Yes you shouldn't use that. The only location it is used the following (forcing strictly higher version).

addon-check/kodi_addon_checker/check_old_addon.py

Lines 46 to 59 in 0929831

	if pr:
	if LooseVersion(addon_version) > LooseVersion(repo_addons_version):
	LOGGER.info("%s addon have greater version: %s than repo_version: %s in branch %s"
	% (addon_name, addon_version, repo_addons_version, branch))
	else:
	report.add(Record(PROBLEM, "%s addon already exists with version: %s in %s branch"
	% (addon_name, repo_addons_version, branch)))
	else:
	if LooseVersion(addon_version) < LooseVersion(repo_addons_version):
	report.add(Record(PROBLEM, "%s addon already exist with version: %s in %s branch"
	% (addon_name, repo_addons_version, branch)))
	else:
	report.add(Record(INFORMATION, "%s addon also exists in %s branch but with version: %s"
	% (addon_name, branch, repo_addons_version)))

[anxdpanic]

@Rechi Thank you for the clarification. I've updated where necessary 👍

[Rechi]

@anxdpanic a new version was released which includes the .git folder fix.

[anxdpanic]

I was looking at adding something to resolve the mentioned log/license warnings
I had a couple ideas on how to approach this;

1. --exclude-file and --exclude-file-ext to exclude file/folder and extensions from permissions and extension whitelist
2. --whitelist-file and --whitelist-file-ext to exclude from extension whitelist
3. both

This would also allow for .pyo/.pyc to be ignored as well when done against a folder

Any suggestions on how this should be approached?

edit: The .git folder fix cleaned up the log quite a bit 👍
https://travis-ci.org/MrSprigster/Twitch-on-Kodi/jobs/488168484

[anxdpanic]

I was able to resolve the initial issue (log and license) within travis ci,
https://github.com/jdf76/plugin.video.youtube/blob/master/.travis.yml#L14
https://travis-ci.org/jdf76/plugin.video.youtube/builds/491251610

[anxdpanic]

This issue was resolved locally and ci outside of kodi-addon-checker