Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license header to python files in add-on check #134

Closed
MartijnKaijser opened this issue Oct 25, 2018 · 3 comments
Closed

Add license header to python files in add-on check #134

MartijnKaijser opened this issue Oct 25, 2018 · 3 comments

Comments

@MartijnKaijser
Copy link
Member

It's encouraged that every python (or whatever) file has a short license reference at the top.

Copyright (C) 2018-2018 Team Kodi
This file is part of Kodi - https://kodi.tv

SPDX-License-Identifier: GPL-3.0-only
See LICENSES/README.md for more information.

@mzfr
Copy link
Contributor

mzfr commented Nov 2, 2018

@MartijnKaijser This one is connected to #126
So now we want to first check if the license exists or not and if it doesn't then we just add it?

@MartijnKaijser
Copy link
Member Author

MartijnKaijser commented Nov 2, 2018

It's not connected. Add-on check itself also needs a license header in the Py files

@mzfr
Copy link
Contributor

mzfr commented Nov 2, 2018

oh, you mean like files in this tool. I thought we have to add it when we are checking the addons. Sorry, my bad :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants