Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore .git folder in create_file_index #143

Merged
merged 2 commits into from
Nov 16, 2018
Merged

ignore .git folder in create_file_index #143

merged 2 commits into from
Nov 16, 2018

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Nov 14, 2018

Skip .git folder, which is inside the add-on path for single add-on repos (upstream repos), for for permission and whitelist checks.

fixes #123

@Rechi Rechi requested a review from razzeee November 14, 2018 10:49
@Rechi Rechi force-pushed the check/fileIndex branch 2 times, most recently from c629ef6 to eece922 Compare November 14, 2018 15:16
@razzeee
Copy link
Member

razzeee commented Nov 15, 2018

So this will also not report on .git folders that get PRed to our repo-* branches. Is that by design?

@Rechi
Copy link
Member Author

Rechi commented Nov 16, 2018

Git doesn't allow to stage (git add) .git folders and therefore also not to commit them.

repo-scripts$ mkdir -p test/.git/
repo-scripts$ touch test/.git/test.txt
repo-scripts$ git add -f test/.git/test.txt
error: Invalid path 'test/.git/test.txt'
error: unable to add test/.git/test.txt to index
fatal: Hinzufügen von Dateien fehlgeschlagen

@razzeee razzeee merged commit d5fe0ff into xbmc:master Nov 16, 2018
@Rechi Rechi deleted the check/fileIndex branch November 16, 2018 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razzeee razzeee Awaiting requested review from razzeee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't process hidden folders
2 participants
@Rechi @razzeee