-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table breaking error reporter #105
Comments
Currently we don't have a good output format. I think we should have a discussion on this. About the issue: In my opinion dropping the table will make it more One thing we can try for longer term is generating HTML file and then render it accordingly. This will be beneficial with the way it look etc etc but again this will not work with Travis-CI Another thing I can think is, which I am not sure can be done or not, make a custom travis-CI parser for ourself. They do have an API(Travis-CI api) so maybe we can think about this. |
Why not try with a different (simpler) |
Yes that's what I meant by git flavoured markdown table. |
To be honest, I still think tables are kinda bad for this. Problems:
I would like to see us try to just use the old construct without a table and just use some formatting to get a nice error message. Could still be pretty table like, but not a table at all.
Something like that might work, just as good |
@razzeee is table still breaking after changing the format? |
We would probably have to do a release to know for sure |
Looks way better now, we should probably also color the tables and not just the first line? |
Can you please show the output once |
See https://travis-ci.org/xbmc/addon-check/jobs/419554450 for example |
If we run the tool locally we can see the whole table in color but travis log doesn't show the colored table. |
Some sign in the table seem to break the report we get back to travis buddy.
Here's an example:
xbmc/repo-plugins#1976
The complete errors can be found here:
https://travis-ci.org/xbmc/repo-plugins/builds/412547630
So either we fix that somehow or we get rid of the table.
The text was updated successfully, but these errors were encountered: