Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limiting needed in import_trakt.py for cleaning lists (-C option) #65

Closed
alcoolfire opened this issue Oct 19, 2024 · 2 comments
Closed

Comments

@alcoolfire
Copy link
Contributor

alcoolfire commented Oct 19, 2024

Bug report #36 identified the need to rate limit list importing and this was fixed by @andrewchenk in #39 by adding a 1-second sleep to api_add_to_list() in import_trakt.py. The same problem exists for cleaning lists (-C option) and is fixed by adding the same sleep to api_remove_from_list().

I've attached the patch I used to repair this for myself. There is a bonus fix in this patch for an infinite loop bug that occurs if the -C option is used when the target list is already empty.

cleaning-lists.patch

@xbgmsharp
Copy link
Owner

hello,
Awesome can you make it a Pull request so the merge is track a proper way. thanks

@xbgmsharp
Copy link
Owner

Done via #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants