From ad7d12e460599995b5b53b9d05881a9a547425d0 Mon Sep 17 00:00:00 2001
From: David Schmitt <david.schmitt@puppetlabs.com>
Date: Mon, 1 Jun 2015 12:21:59 +0100
Subject: [PATCH] Remove duplicate rake task and enable metadata.json linting

The :validate task is already provided by
puppetlabs_spec_helper/rake_tasks and would check files twice.

The metadata.json linting is just good form.
---
 Gemfile  |  1 +
 Rakefile | 12 ------------
 2 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/Gemfile b/Gemfile
index 82a520427..9d38f35e7 100644
--- a/Gemfile
+++ b/Gemfile
@@ -17,6 +17,7 @@ group :development, :unit_tests do
   gem 'mocha',                   :require => false
   gem 'puppetlabs_spec_helper',  :require => false
   gem 'puppet-lint',             :require => false
+  gem 'metadata-json-lint',      :require => false
   gem 'pry',                     :require => false
   gem 'simplecov',               :require => false
 end
diff --git a/Rakefile b/Rakefile
index 4ed1327a3..13ee3d9b7 100644
--- a/Rakefile
+++ b/Rakefile
@@ -4,15 +4,3 @@ require 'puppet-lint/tasks/puppet-lint'
 PuppetLint.configuration.send('disable_80chars')
 PuppetLint.configuration.ignore_paths = ["spec/**/*.pp", "pkg/**/*.pp"]
 
-desc "Validate manifests, templates, and ruby files in lib."
-task :validate do
-  Dir['manifests/**/*.pp'].each do |manifest|
-    sh "puppet parser validate --noop #{manifest}"
-  end
-  Dir['lib/**/*.rb'].each do |lib_file|
-    sh "ruby -c #{lib_file}"
-  end
-  Dir['templates/**/*.erb'].each do |template|
-    sh "erb -P -x -T '-' #{template} | ruby -c"
-  end
-end