Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DH.derive_key uses SHA1, which is deprecated #19

Closed
UnixJunkie opened this issue Sep 27, 2019 · 3 comments
Closed

DH.derive_key uses SHA1, which is deprecated #19

UnixJunkie opened this issue Sep 27, 2019 · 3 comments

Comments

@UnixJunkie
Copy link
Contributor

As a European citizen, I would prefer RIPEMD160, but I am not a specialist of those things.
@UnixJunkie
Copy link
Contributor Author

A specialist advises SHA256:
https://crypto.stackexchange.com/questions/957/ripemd-versus-sha-x-what-are-the-main-pros-and-cons

@UnixJunkie UnixJunkie mentioned this issue Sep 27, 2019
Merged
@xavierleroy
Copy link
Owner

Fixed by #20 .

@UnixJunkie
Copy link
Contributor Author

Thanks for your responsiveness.
Maybe a new minor release (a git tag) is in order, so that the opam package can be updated.
I know that a fix related to zlib was included recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@UnixJunkie @xavierleroy