-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set crs in attrs. #71
Comments
I think I know the reason we originally did this. When selecting via a scalar coordinate from GeometryIndex, the result no longer has an index along the dimension, hence loses information on CRS. So when using the ds = traffic_dataset.sel(
origin=shapely.Point(1, 2), day="2023-01-01", mode="car"
)
|
Yes I think this is where the |
That is a great idea! We've been working on that with @scottyhq, the result is here: https://github.com/benbovy/xproj 🙂 (still experimental and very much work in progress). |
Could've called it |
Ah yes |
Currently the crs is duplicated in attrs and on the index.
The edge-case to handle is when you select with a scalar the index is dropped. In this case we may want to set it on the variable attrs in
IndexSelResult
.This commit is a good starting point.
The text was updated successfully, but these errors were encountered: