From 8998676eeccf2eeaa2126e87b95c93dbf06ce723 Mon Sep 17 00:00:00 2001 From: Anderson Banihirwe Date: Wed, 9 Oct 2024 16:30:45 -0700 Subject: [PATCH 1/2] Remove xfail mark for False case in test_batch_3d_1d_input due to resolved bug --- xbatcher/tests/test_generators.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/xbatcher/tests/test_generators.py b/xbatcher/tests/test_generators.py index 166648c..b0939dc 100644 --- a/xbatcher/tests/test_generators.py +++ b/xbatcher/tests/test_generators.py @@ -224,12 +224,6 @@ def test_batch_3d_1d_input(sample_ds_3d, input_size): 'concat', [ True, - pytest.param( - False, - marks=pytest.mark.xfail( - reason='Bug described in https://github.com/xarray-contrib/xbatcher/issues/126' - ), - ), ], ) def test_batch_3d_1d_input_batch_dims(sample_ds_3d, concat): From 721e403a5ef52abfa3d749b36689e86715273c05 Mon Sep 17 00:00:00 2001 From: Anderson Banihirwe Date: Thu, 10 Oct 2024 16:22:50 -0700 Subject: [PATCH 2/2] Add False case to test_batch_3d_1d_input_batch_dims --- xbatcher/tests/test_generators.py | 1 + 1 file changed, 1 insertion(+) diff --git a/xbatcher/tests/test_generators.py b/xbatcher/tests/test_generators.py index b0939dc..3665ba7 100644 --- a/xbatcher/tests/test_generators.py +++ b/xbatcher/tests/test_generators.py @@ -224,6 +224,7 @@ def test_batch_3d_1d_input(sample_ds_3d, input_size): 'concat', [ True, + False, ], ) def test_batch_3d_1d_input_batch_dims(sample_ds_3d, concat):