Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify xbatcher license #99

Closed
maxrjones opened this issue Oct 6, 2022 · 5 comments · Fixed by #110
Closed

Clarify xbatcher license #99

maxrjones opened this issue Oct 6, 2022 · 5 comments · Fixed by #110
Labels
question Further information is requested

Comments

@maxrjones
Copy link
Member

What is your issue?

The license file for xbatcher is MIT, but the package metadata lists Apache. @rabernat, as the original author can you confirm the correct license for xbatcher? I can update accordingly afterwards.

@jhamman
Copy link
Contributor

jhamman commented Oct 8, 2022

I favor the Apache license for projects with multiple contributors. Therefore, I suggest we change the license file to the Apache license to line up with the package metadata.

@weiji14
Copy link
Member

weiji14 commented Oct 10, 2022

Does this count as relicensing? I would have thought the LICENSE file is the correct source, but looking at git blame, the 'Apache' license metadata added 28 Oct 2018 at https://github.com/xarray-contrib/xbatcher/blame/a36a958d709900eb5dc6af700e0d21b22f3e55ed/setup.py#L14 actually came before the 'MIT' license file added on 4 Nov 2018 in 3e71e44, so not sure what's the original intention. Maybe wait for @rabernat to clarify things 🙂

In any case, the text at

Copyright (c) 2016 Ryan Abernathey
should probably be updated to say 'Xbatcher developers' or something along those lines.

@maxrjones
Copy link
Member Author

My intuition was the same as yours that the LICENSE file would have taken precedence, but I'm not a lawyer either... As you suggested, we can wait for clarification about the intention here in order to determine whether this was a bug. Relicensing would be complicated but not impossible given the number of contributors.

@maxrjones
Copy link
Member Author

Respectfully pinging @rabernat to help resolve this issue. To summarize, we need to know whether the xbatcher project was intended to be licensed as Apache, MIT, or both. I would greatly appreciate your input so we can make any necessary fixes prior to the upcoming release.

@rabernat
Copy link
Contributor

rabernat commented Oct 14, 2022

Sorry for the slow reply. Really no strong preference from me. I created this in a hurry without giving too much thought to the license, and clearly I made a mistake by creating this inconsistent metadata. I support whatever path is easiest / preferred by the current contributors.

Apache and MIT are highly compatible, so hopefully not too hard to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants