Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the provided argument in Variable init #20

Closed
benbovy opened this issue Nov 10, 2017 · 2 comments
Closed

Rename the provided argument in Variable init #20

benbovy opened this issue Nov 10, 2017 · 2 comments
Milestone
0.2

Comments

@benbovy
Copy link
Member

benbovy commented Nov 10, 2017

This issue is to track ideas to improve the API. This project is still young so we can make breaking changes.

  • in Variable and ForeignVariable, rename provided argument to yield_value (more meaningful).
@benbovy benbovy mentioned this issue Nov 22, 2017
Closed
@benbovy
Copy link
Member Author

benbovy commented Jan 16, 2018

rename provided argument to yield_value (more meaningful).

Even more meaningful would be intent='input' or intent='output'.

@benbovy benbovy changed the title Small improvements for the API of the framework Rename the provided argument in Variable init Jan 22, 2018
@benbovy benbovy added this to the 0.2 milestone Feb 27, 2018
@benbovy benbovy mentioned this issue Mar 8, 2018
Merged
@benbovy
Copy link
Member Author

benbovy commented May 7, 2018

Closed in #33

@benbovy benbovy closed this as completed May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
1 participant
@benbovy