You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I feel a bit guilty that #164 was initially about visualizing inout variables, but that has not been properly addressed in the following discussion or PRs. Furthermore, the checking algorithm works, but may be a bit aggressive. The user still does not really have a good way to see all relationships, such as seeming cycles as @jvail initially intendet. Therefore, the following proposal for two different options in the visualisation:
the initial proposal by @jvail. Add dotted arrows from the last inout process to all first in processes for all variables. as an option in visualise model.visualize(cycle_arrows=True) e.g.:
in->inout->inout->in
^ /
\- dotted -/
add color enhancement for a single variable. Possibly as an enhancement of show_only_variable or separate model.visualize(show_variable_stages='p_name__var_name')
added an example notebook for why 2. is useful. For example when a user does not understand the error messages of strict_check, they can still visualize the graph with the different stages of that variable.
I feel a bit guilty that #164 was initially about visualizing inout variables, but that has not been properly addressed in the following discussion or PRs. Furthermore, the checking algorithm works, but may be a bit aggressive. The user still does not really have a good way to see all relationships, such as seeming cycles as @jvail initially intendet. Therefore, the following proposal for two different options in the visualisation:
inout
process to all firstin
processes for all variables. as an option in visualisemodel.visualize(cycle_arrows=True)
e.g.:show_only_variable
or separatemodel.visualize(show_variable_stages='p_name__var_name')
This would make it clear for the user if processes are updated or not before they are used.
Both require a similar algorithm to work, but 2 is quite more complex to implement.
The text was updated successfully, but these errors were encountered: