Accounting for NoneType coordinates in attrs/encoding #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
reviewed
Aug 15, 2022
dcherian
reviewed
Aug 15, 2022
cf_xarray/accessor.py
Outdated
| search_in.update(obj.encoding["coordinates"].split(" ")) | ||
| if "coordinates" in obj.attrs: | ||
| search_in.update(obj.attrs["coordinates"].split(" ")) | ||
| coordinates = obj.encoding.get("coordinates", None) |
There was a problem hiding this comment.
Suggested change
| coordinates = obj.encoding.get("coordinates", None) | |
| attrs_or_encoding = ChainMap(self._obj[name].attrs, self._obj[name].encoding) | |
| coordinates = attrs_or_encoding.get("coordinates", None) |
There was a problem hiding this comment.
I was not sure if it was intentional that here a set of attrs["coordinates"] and encoding["coordinates"] is being constructed and not the ChainMap operator is being used (which respects then only the first mention of "coordinates" in attrs and encoding).
There was a problem hiding this comment.
Oh nice catch. I think we should treat coordinates in both attrs and encoding as a bug perhaps.
dcherian
reviewed
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With pydata/xarray#5514 it has become practice (at least for me) to occasionally disable the coordinates attribute to be written to file by setting
ds['var'].encoding['coordinates'] = None. If used too generously, this may however lead to an AttributeError in the cf-xarray accessor:I suggest this small update to keep that from happening.