-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A cf-xarray compliance checker? #366
Comments
A number of these exist:
so i don't think we should reinvent it. It would be nice if we could run the checker on a Dataset using cc @ocefpaf |
For another project I've been looking at CF checkers last week, and it looks like all options are mostly command-line tools meant to check NetCDF files. It would be great if |
It'd be nice to build an API connection, but worst case we can write a tiny dataset with all attributes to |
I have mixed feelings. While I don't want to overload
I guess that, instead of becoming a compliance-checker cf-xarray could have a "verbose mode" where all the compliance issues would be printed when loading a dataset. |
This is hard to define! |
Indeed! That is why cc is super verbose, kind of all or nothing. However, @kthyng suggestion above looks like a nice start:
More than that we would get into the weeds of CF but those 3 lines ensure almost all of plotting with labels. |
I wrote some tests for a package: https://github.com/NOAA-ORR-ERD/model_catalogs/blob/main/model_catalogs/tests/test_catalogs.py#L326-L369 When the models are read in with the package, they should be able to be used by |
NASA-specific compliance checker: https://github.com/eugenegesdisc/diwg-data-compliance-test |
I'd suggest allowing
Everything mentioned in
I'd suggest a fourth check for |
Would something like this be in scope for cf-xarray? It would need to be fairly loosely defined, but maybe a minimum would be that a Dataset would have axes and coordinates all defined? Variables would need standard_names? Though some variables don't usually have standard names like maybe "angle" on a ROMS grid.
The text was updated successfully, but these errors were encountered: