Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Update go-querystring to a version that handles references to slices properly #1333

Closed
Bouwdie opened this issue Jan 4, 2022 · 0 comments · Fixed by #1334
Closed

Update go-querystring to a version that handles references to slices properly #1333

Bouwdie opened this issue Jan 4, 2022 · 0 comments · Fixed by #1334

Comments

@Bouwdie
Copy link
Contributor

Bouwdie commented Jan 4, 2022

@svanharmelen Thanks for the commits and the fix. I unfortunately am not used to the new review interface of github and didn't push my remarks. One this I would like to stress is to update the go-querystring dependency, refences to slices will otherwise not be encoded properly aka project.Tags[] for example. Thanks again 💯

Originally posted by @Bouwdie in #1318 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant