This repository has been archived by the owner on May 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When disposing renderers the framework need to unsubscribe events,
because of the different lifetime between the two parts this often cause memory leaks and dispose issues.
For the DotNet part the form is an event with +=/-=, in several past PR I fixed some missing calls of this form.
But for Android part the form is different, it's SetListener or AddListener, and RemoveListener.
I have checked Android renderers code and found that some renderers lack the removal of the setted listeners.
The goal of this PR is to add the missing ones.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
As always with dispose and memory leaks issues, not possible to directly test it, just check if current tests not regress.
PR Checklist