This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fix NRE when using Custom Slide Transition #13494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
ShellFlyoutRenderer wasn't correctly checking for scenarios where users are implementing a Custom Slide Flyout Transition class which was causing an NRE. I've also set the
LayoutViews
method to be virtual and add madeUpdateFlyoutSize
public so users can reuse SlideFlyoutTransitionIssues Resolved
API Changes
Added:
Changed:
Platforms Affected
Testing Procedure
PR Checklist