[CoreData] Move CoreData into the .NET age. #13692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all the CoreData API to be better as defined by our XAMCORE_4_0 define. Mostly using generic NSSet/NSDictionary types instead of the non-generic ones, and other misc naming improvements.
rolfbjarne
added
not-notes-worthy
mandel-macaque
approved these changes
Jan 13, 2022
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results27 tests failed, 121 tests passed.Failed tests
Pipeline on Agent XAMBOT-1101.BigSur' |
tj-devel709
reviewed
Jan 13, 2022
| @@ -120,7 +120,11 @@ public void Sections () | |||
| var storeUrl = new NSUrl (storePath, false); | |||
| NSError error; | |||
|
|
|||
| #if NET | |||
| if (PersistentStoreCoordinator.AddPersistentStore (NSPersistentStoreCoordinator.SQLiteStoreType, null, storeUrl, null, out error) == null) { | |||
There was a problem hiding this comment.
Suggested change
| if (PersistentStoreCoordinator.AddPersistentStore (NSPersistentStoreCoordinator.SQLiteStoreType, null, storeUrl, null, out error) == null) { | |
| if (PersistentStoreCoordinator.AddPersistentStore (NSPersistentStoreCoordinator.SQLiteStoreType, null, storeUrl, null, out error) is null) { |
maybe
tj-devel709
approved these changes
Jan 13, 2022
|
I'm going to redo this without the generic changes, because of #13704. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all the CoreData API to be better as defined by our XAMCORE_4_0 define. Mostly
using generic NSSet/NSDictionary types instead of the non-generic ones, and other
misc naming improvements.