Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[net10.0] Trim by default (SdkOnly) when building for arm64. Fixes #21444. #21461

Merged
merged 2 commits into from
Oct 23, 2024
Merged

[net10.0] Trim by default (SdkOnly) when building for arm64. Fixes #21444. #21461

merged 2 commits into from
Oct 23, 2024

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Oct 16, 2024 •
edited
Loading

The default build times for a Mac Catalyst app on arm64 are horrendous:

  • dotnet new maccatalyst && dotnet build: 1 minute

Enabling the trimmer or the interpreter makes it much better:

  • dotnet new maccatalyst && dotnet build /p:UseInterpreter: 17 seconds
  • dotnet new maccatalyst && dotnet build /p:TrimMode=partial: 12 seconds
  • dotnet new maccatalyst && dotnet build /p:TrimMode=full: 12 seconds
  • dotnet new maccatalyst && dotnet build /p:TrimMode=partial /p:UseInterpreter=true: 12 seconds

So enable the trimmer by default for Debug mode on ARM64 on:

  • iOS
  • tvOS
  • Mac Catalyst

(we're already trimming for other build configurations, so it seemed like an easy to choice to enable the trimmer in these configurations as well, as opposed to enabling the interpreter)

Fixes #21444.

@rolfbjarne rolfbjarne linked an issue Oct 16, 2024 that may be closed by this pull request
Improve default build times on arm64 #21444
Open
@rolfbjarne rolfbjarne added the notes-mention Deserves a mention in release notes label Oct 16, 2024
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: d3992850f5d9099c9e9ae92e8c8234299267c83d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: d3992850f5d9099c9e9ae92e8c8234299267c83d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: d3992850f5d9099c9e9ae92e8c8234299267c83d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: d3992850f5d9099c9e9ae92e8c8234299267c83d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: d3992850f5d9099c9e9ae92e8c8234299267c83d [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 99 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: d3992850f5d9099c9e9ae92e8c8234299267c83d [PR build]

@rolfbjarne rolfbjarne marked this pull request as ready for review October 17, 2024 17:02
mcumming
mcumming approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@mcumming mcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have any side-effect for Hot Reload?

@rolfbjarne
Copy link
Member Author

Does this have any side-effect for Hot Reload?

Hot Reload already works on iOS device, where we're already trimming by default. This means that if Hot Reload requires trimming to be disabled, then it's already disabling it - so unless Hot Reload is disabling trimming exclusively for device builds, which would be a weird thing to do, it should continue to work fine (famous las words!)

@rolfbjarne
Copy link
Member Author

MAUI disables trimming for both iOS and Mac Catalyst as long as the project is building for Debug:

https://github.com/dotnet/maui/blob/4c75db4795b8abbc810eae4c7f4acc9ac2e2e24a/src/Controls/src/Build.Tasks/nuget/buildTransitive/net6.0-ios10.0/Microsoft.Maui.Controls.iOS.targets#L4

https://github.com/dotnet/maui/blob/4c75db4795b8abbc810eae4c7f4acc9ac2e2e24a/src/Controls/src/Build.Tasks/nuget/buildTransitive/net6.0-maccatalyst13.1/Microsoft.Maui.Controls.MacCatalyst.targets#L4

So I believe this should be fine with regards to Hot Reload.

@rolfbjarne rolfbjarne merged commit 54c299c into net10.0 Oct 23, 2024
21 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/net10.0-trim-arm64-by-default branch October 23, 2024 19:17
@rolfbjarne
Copy link
Member Author

CC @Redth for awareness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcumming mcumming mcumming approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
notes-mention Deserves a mention in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve default build times on arm64
5 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @mandel-macaque @mcumming