Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/installer #7255

Merged
merged 14 commits into from
Aug 18, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 12, 2022

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.ILLink.Tasks: from 7.0.100-1.22377.1 to 7.0.100-1.22415.4 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.NETCore.App.Ref: from 7.0.0-rc.1.22403.8 to 7.0.0-rc.1.22411.12 (parent: Microsoft.Dotnet.Sdk.Internal)

From https://github.com/dotnet/installer

  • Subscription: 97ee8954-2ef3-4217-5719-08da2edb85ba
  • Build: 20220817.1
  • Date Produced: August 17, 2022 8:30:55 AM UTC
  • Commit: f3da421a6e81382d6d2b25b236697f33e210092c
  • Branch: refs/heads/release/7.0.1xx

…220812.1

Microsoft.Dotnet.Sdk.Internal
 From Version 7.0.100-rc.1.22409.23 -> To Version 7.0.100-rc.1.22412.1

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref
 From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22411.2 (parent: Microsoft.Dotnet.Sdk.Internal
Context: dotnet/runtime#71203
Fixes: #7249

Apps on this PR currently crash with:

    mono-rt : [ERROR] FATAL UNHANDLED EXCEPTION: System.InvalidProgramException: Invalid IL code in (wrapper managed-to-native) object:wrapper_native_0x7725af156f10 (intptr): IL_0012: calli     0x00000003
    mono-rt :    at System.Runtime.InteropServices.Marshal.PtrToStructureHelper(IntPtr , Object , Boolean )
    mono-rt :    at System.Runtime.InteropServices.Marshal.PtrToStructure(IntPtr , Type )
    mono-rt :    at Java.Interop.JniRuntime.CreateInvoker(IntPtr )
    mono-rt :    at Java.Interop.JniRuntime..ctor(CreationOptions )
    mono-rt :    at Android.Runtime.AndroidRuntime..ctor(IntPtr , IntPtr , Boolean , IntPtr , IntPtr , Boolean )
    mono-rt :    at Android.Runtime.JNIEnv.Initialize(JnienvInitializeArgs* )

Which, I assume is due to a missing Mono component.

We should add the component by default:

    <_MonoComponent Condition=" '$(_IncludeMarshalIlGen)' != 'false' " Include="marshal-ilgen" />

In the future, someone could experiment by setting
`$(_IncludeMarshalIlGen)` to `false`.
@dotnet-maestro dotnet-maestro bot requested a review from dellis1972 as a code owner August 12, 2022 19:06
@jonathanpeppers jonathanpeppers force-pushed the darc-main-5239d12a-fa8e-406c-828a-c43e5bdac23e branch from 96acf95 to 303f41f Compare August 15, 2022 03:04
dotnet-maestro bot and others added 2 commits August 15, 2022 12:39
…220814.7

Microsoft.Dotnet.Sdk.Internal
 From Version 7.0.100-rc.1.22409.23 -> To Version 7.0.100-rc.1.22414.7

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref
 From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22412.1 (parent: Microsoft.Dotnet.Sdk.Internal
Context: dotnet/linker#2929
Context: https://github.com/dotnet/linker/blob/6e8e139a484f74c524c821c7a4a08287d77257a4/src/ILLink.Tasks/build/Microsoft.NET.ILLink.targets#L227-L229
Fixes: #7256

Serialization heuristics in the .NET 7 linker is now opt-in.

We now need to pass a new flag to the linker by default:

    <_ExtraTrimmerArgs>--enable-serialization-discovery $(_ExtraTrimmerArgs)</_ExtraTrimmerArgs>

This might also solve project builds in `Release` mode that appear to
hang:

    Task "ILLink" (TaskId:272)

Builds appear to be running this task and never exit. Let's hope this
also solves this?
jonathanpeppers and others added 7 commits August 17, 2022 08:29
…220817.1

Microsoft.Dotnet.Sdk.Internal
 From Version 7.0.100-rc.1.22409.23 -> To Version 7.0.100-rc.2.22417.1

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref
 From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22415.4 (parent: Microsoft.Dotnet.Sdk.Internal
@jonathanpeppers
Copy link
Member

Ok, wow one test hit:

    Errors
        ILLink error IL1012: IL Trimmer has encountered an unexpected error. Please report the issue at https://github.com/dotnet/linker/issues [C:\a\_work\1\a\TestRelease\08-18_15.04.47\temp\BuildAMassiveApp\App1\App1.csproj]
    Fatal error in IL Linker
    Unhandled exception. System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
       at Mono.Cecil.MetadataReader.RangesSize(Range[] ranges)
       at Mono.Cecil.MetadataReader.ReadCustomAttributes(ICustomAttributeProvider owner)
       at Mono.Cecil.Mixin.<>c.<GetCustomAttributes>b__13_0(ICustomAttributeProvider provider, MetadataReader reader)
       at Mono.Cecil.ModuleDefinition.Read[TItem,TRet](TRet& variable, TItem item, Func`3 read)
       at Mono.Cecil.Mixin.GetCustomAttributes(ICustomAttributeProvider self, Collection`1& variable, ModuleDefinition module)
       at Mono.Cecil.FieldDefinition.get_CustomAttributes()
       at Microsoft.Android.Sdk.ILLink.ApplyPreserveAttribute.GetPreserveAttributes(ICustomAttributeProvider provider) in /Users/builder/azdo/_work/1/s/xamarin-android/src/Microsoft.Android.Sdk.ILLink/ApplyPreserveAttribute.cs:line 143
       at Microsoft.Android.Sdk.ILLink.ApplyPreserveAttribute.ProcessField(FieldDefinition field) in /Users/builder/azdo/_work/1/s/xamarin-android/src/Microsoft.Android.Sdk.ILLink/ApplyPreserveAttribute.cs:line 38
       at Mono.Linker.Steps.MarkSubStepsDispatcher.DispatchField(FieldDefinition field)
       at Mono.Linker.Steps.MarkSubStepsDispatcher.BrowseTypes(Collection`1 types)
       at Mono.Linker.Steps.MarkSubStepsDispatcher.BrowseTypes(Collection`1 types)
       at Mono.Linker.Steps.MarkSubStepsDispatcher.BrowseAssembly(AssemblyDefinition assembly)
       at Mono.Linker.Steps.MarkSubStepsDispatcher.<Initialize>b__5_0(AssemblyDefinition assembly)
       at Mono.Linker.Steps.MarkStep.MarkAssembly(AssemblyDefinition assembly, DependencyInfo reason)
       at Mono.Linker.Steps.MarkStep.MarkModule(ModuleDefinition module, DependencyInfo reason)
       at Mono.Linker.Steps.MarkStep.MarkType(TypeReference reference, DependencyInfo reason, Nullable`1 origin)
       at Mono.Linker.Steps.MarkStep.ProcessMarkedPending()
       at Mono.Linker.Steps.MarkStep.Initialize()
       at Mono.Linker.Steps.MarkStep.Process(LinkContext context)
       at Mono.Linker.Pipeline.ProcessStep(LinkContext context, IStep step)
       at Mono.Linker.Pipeline.Process(LinkContext context)
       at Mono.Linker.Driver.Run(ILogger customLogger)
       at Mono.Linker.Driver.Main(String[] args)
    The command exited with code 57005.

This test is the one that builds an app with 100 class libraries.

Let me rerun & potentially file an issue. We can also disable this test for now.

@jonathanpeppers
Copy link
Member

This passed on rerun: #7255 (comment)

I'll keep an eye on it and file an issue if we need to.

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only failure are these, which are occasionally happening in main:

image

The designer tests are also failing in main.

@jonathanpeppers jonathanpeppers merged commit 102982b into main Aug 18, 2022
@jonathanpeppers jonathanpeppers deleted the darc-main-5239d12a-fa8e-406c-828a-c43e5bdac23e branch August 18, 2022 18:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant