From a92b164201770e1bbb2f3377854b707fa7e5d9d7 Mon Sep 17 00:00:00 2001
From: Phillip Carter <pcarter@fastmail.com>
Date: Tue, 17 Nov 2020 15:41:19 -0800
Subject: [PATCH] Add ConvertToSingleEqualsEqualityExpression code fix (#10462)

* Add ConvertToSingleEqualsEqualityExpression code fix

* Fix type
---
 ...ConvertToSingleEqualsEqualityExpression.fs | 46 +++++++++++++++++++
 FSharp.Editor.fsproj                          |  5 ++
 FSharp.Editor.resx                            |  3 ++
 xlf/FSharp.Editor.cs.xlf                      |  5 ++
 xlf/FSharp.Editor.de.xlf                      |  5 ++
 xlf/FSharp.Editor.es.xlf                      |  5 ++
 xlf/FSharp.Editor.fr.xlf                      |  5 ++
 xlf/FSharp.Editor.it.xlf                      |  5 ++
 xlf/FSharp.Editor.ja.xlf                      |  5 ++
 xlf/FSharp.Editor.ko.xlf                      |  5 ++
 xlf/FSharp.Editor.pl.xlf                      |  5 ++
 xlf/FSharp.Editor.pt-BR.xlf                   |  5 ++
 xlf/FSharp.Editor.ru.xlf                      |  5 ++
 xlf/FSharp.Editor.tr.xlf                      |  5 ++
 xlf/FSharp.Editor.zh-Hans.xlf                 |  5 ++
 xlf/FSharp.Editor.zh-Hant.xlf                 |  5 ++
 16 files changed, 119 insertions(+)
 create mode 100644 CodeFix/ConvertToSingleEqualsEqualityExpression.fs

diff --git a/CodeFix/ConvertToSingleEqualsEqualityExpression.fs b/CodeFix/ConvertToSingleEqualsEqualityExpression.fs
new file mode 100644
index 00000000000..e87538d1b88
--- /dev/null
+++ b/CodeFix/ConvertToSingleEqualsEqualityExpression.fs
@@ -0,0 +1,46 @@
+// Copyright (c) Microsoft Corporation.  All Rights Reserved.  See License.txt in the project root for license information.
+
+namespace Microsoft.VisualStudio.FSharp.Editor
+
+open System.Composition
+open System.Threading
+open System.Threading.Tasks
+
+open Microsoft.CodeAnalysis.Text
+open Microsoft.CodeAnalysis.CodeFixes
+open Microsoft.CodeAnalysis.CodeActions
+
+[<ExportCodeFixProvider(FSharpConstants.FSharpLanguageName, Name = "ConvertToSingleEqualsEqualityExpression"); Shared>]
+type internal FSharpConvertToSingleEqualsEqualityExpressionCodeFixProvider() =
+    inherit CodeFixProvider()
+
+    let fixableDiagnosticIds = set ["FS0043"]
+
+    override __.FixableDiagnosticIds = Seq.toImmutableArray fixableDiagnosticIds
+
+    override this.RegisterCodeFixesAsync context : Task =
+        asyncMaybe {
+            let! sourceText = context.Document.GetTextAsync(context.CancellationToken)
+            let text = sourceText.GetSubText(context.Span).ToString()
+
+            // We're converting '==' into '=', a common new user mistake.
+            // If this is an FS00043 that is anything other than that, bail out
+            do! Option.guard (text = "==")
+
+            let title = SR.ConvertToSingleEqualsEqualityExpression()
+
+            let diagnostics =
+                context.Diagnostics
+                |> Seq.filter (fun x -> fixableDiagnosticIds |> Set.contains x.Id)
+                |> Seq.toImmutableArray
+
+            let codeFix =
+                CodeFixHelpers.createTextChangeCodeFix(
+                    title,
+                    context,
+                    (fun () -> asyncMaybe.Return [| TextChange(context.Span, "=") |]))
+
+            context.RegisterCodeFix(codeFix, diagnostics)
+        }
+        |> Async.Ignore
+        |> RoslynHelpers.StartAsyncUnitAsTask(context.CancellationToken)
\ No newline at end of file
diff --git a/FSharp.Editor.fsproj b/FSharp.Editor.fsproj
index f7cb5d028d3..8fec16bd4ea 100644
--- a/FSharp.Editor.fsproj
+++ b/FSharp.Editor.fsproj
@@ -3,6 +3,10 @@
   <Import Project="$(ReferencesVSEditor)" />
   <Import Project="$(ReferencesGtk)" />
   <Import Project="VSMac\templates\templates.targets" />
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright (c) Microsoft Corporation.  All Rights Reserved.  See License.txt in the project root for license information. -->
+<Project Sdk="Microsoft.NET.Sdk">
+
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
@@ -180,6 +184,7 @@
     <Compile Include="Commands\FsiCommandService.fs" />
     <Compile Include="Commands\XmlDocCommandService.fs" />
     <Compile Include="CodeFix\CodeFixHelpers.fs" />
+    <Compile Include="CodeFix\ConvertToSingleEqualsEqualityExpression.fs" />
     <Compile Include="CodeFix\ChangeRefCellDerefToNotExpression.fs" />
     <Compile Include="CodeFix\WrapExpressionInParentheses.fs" />
     <Compile Include="CodeFix\ChangePrefixNegationToInfixSubtraction.fs" />
diff --git a/FSharp.Editor.resx b/FSharp.Editor.resx
index 94f2d6c4c58..720e90003b3 100644
--- a/FSharp.Editor.resx
+++ b/FSharp.Editor.resx
@@ -219,6 +219,9 @@
   <data name="FSharpDisposableTopLevelValuesClassificationType" xml:space="preserve">
     <value>F# Dispostable Values (top-level)</value>
   </data>
+  <data name="ConvertToSingleEqualsEqualityExpression" xml:space="preserve">
+    <value>Use '=' for equality check</value>
+  </data>
   <data name="UseNotForNegation" xml:space="preserve">
     <value>Use 'not' to negate expression</value>
   </data>
diff --git a/xlf/FSharp.Editor.cs.xlf b/xlf/FSharp.Editor.cs.xlf
index b1c154e6166..39301e1124a 100644
--- a/xlf/FSharp.Editor.cs.xlf
+++ b/xlf/FSharp.Editor.cs.xlf
@@ -7,6 +7,11 @@
         <target state="translated">Přidejte klíčové slovo new.</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConvertToSingleEqualsEqualityExpression">
+        <source>Use '=' for equality check</source>
+        <target state="new">Use '=' for equality check</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ChangePrefixNegationToInfixSubtraction">
         <source>Use subtraction instead of negation</source>
         <target state="new">Use subtraction instead of negation</target>
diff --git a/xlf/FSharp.Editor.de.xlf b/xlf/FSharp.Editor.de.xlf
index 728a4f2e556..c6b772545b4 100644
--- a/xlf/FSharp.Editor.de.xlf
+++ b/xlf/FSharp.Editor.de.xlf
@@ -7,6 +7,11 @@
         <target state="translated">Schlüsselwort "new" hinzufügen</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConvertToSingleEqualsEqualityExpression">
+        <source>Use '=' for equality check</source>
+        <target state="new">Use '=' for equality check</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ChangePrefixNegationToInfixSubtraction">
         <source>Use subtraction instead of negation</source>
         <target state="new">Use subtraction instead of negation</target>
diff --git a/xlf/FSharp.Editor.es.xlf b/xlf/FSharp.Editor.es.xlf
index 3a42ab5f955..156379e248a 100644
--- a/xlf/FSharp.Editor.es.xlf
+++ b/xlf/FSharp.Editor.es.xlf
@@ -7,6 +7,11 @@
         <target state="translated">Agregar "nueva" palabra clave</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConvertToSingleEqualsEqualityExpression">
+        <source>Use '=' for equality check</source>
+        <target state="new">Use '=' for equality check</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ChangePrefixNegationToInfixSubtraction">
         <source>Use subtraction instead of negation</source>
         <target state="new">Use subtraction instead of negation</target>
diff --git a/xlf/FSharp.Editor.fr.xlf b/xlf/FSharp.Editor.fr.xlf
index 9dc3d3c8256..0d06914bd12 100644
--- a/xlf/FSharp.Editor.fr.xlf
+++ b/xlf/FSharp.Editor.fr.xlf
@@ -7,6 +7,11 @@
         <target state="translated">Ajouter le mot clé 'new'</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConvertToSingleEqualsEqualityExpression">
+        <source>Use '=' for equality check</source>
+        <target state="new">Use '=' for equality check</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ChangePrefixNegationToInfixSubtraction">
         <source>Use subtraction instead of negation</source>
         <target state="new">Use subtraction instead of negation</target>
diff --git a/xlf/FSharp.Editor.it.xlf b/xlf/FSharp.Editor.it.xlf
index 03e9a26b0a3..d9b4ae18f3b 100644
--- a/xlf/FSharp.Editor.it.xlf
+++ b/xlf/FSharp.Editor.it.xlf
@@ -7,6 +7,11 @@
         <target state="translated">Aggiungi la parola chiave 'new'</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConvertToSingleEqualsEqualityExpression">
+        <source>Use '=' for equality check</source>
+        <target state="new">Use '=' for equality check</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ChangePrefixNegationToInfixSubtraction">
         <source>Use subtraction instead of negation</source>
         <target state="new">Use subtraction instead of negation</target>
diff --git a/xlf/FSharp.Editor.ja.xlf b/xlf/FSharp.Editor.ja.xlf
index 94a636ea333..98b6321c3e7 100644
--- a/xlf/FSharp.Editor.ja.xlf
+++ b/xlf/FSharp.Editor.ja.xlf
@@ -7,6 +7,11 @@
         <target state="translated">'new' キーワードを追加する</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConvertToSingleEqualsEqualityExpression">
+        <source>Use '=' for equality check</source>
+        <target state="new">Use '=' for equality check</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ChangePrefixNegationToInfixSubtraction">
         <source>Use subtraction instead of negation</source>
         <target state="new">Use subtraction instead of negation</target>
diff --git a/xlf/FSharp.Editor.ko.xlf b/xlf/FSharp.Editor.ko.xlf
index 9bc5464d9a8..846f4f1f59f 100644
--- a/xlf/FSharp.Editor.ko.xlf
+++ b/xlf/FSharp.Editor.ko.xlf
@@ -7,6 +7,11 @@
         <target state="translated">'new' 키워드 추가</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConvertToSingleEqualsEqualityExpression">
+        <source>Use '=' for equality check</source>
+        <target state="new">Use '=' for equality check</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ChangePrefixNegationToInfixSubtraction">
         <source>Use subtraction instead of negation</source>
         <target state="new">Use subtraction instead of negation</target>
diff --git a/xlf/FSharp.Editor.pl.xlf b/xlf/FSharp.Editor.pl.xlf
index aff222fbe9c..04349ea8fee 100644
--- a/xlf/FSharp.Editor.pl.xlf
+++ b/xlf/FSharp.Editor.pl.xlf
@@ -7,6 +7,11 @@
         <target state="translated">Dodaj słowo kluczowe „new”</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConvertToSingleEqualsEqualityExpression">
+        <source>Use '=' for equality check</source>
+        <target state="new">Use '=' for equality check</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ChangePrefixNegationToInfixSubtraction">
         <source>Use subtraction instead of negation</source>
         <target state="new">Use subtraction instead of negation</target>
diff --git a/xlf/FSharp.Editor.pt-BR.xlf b/xlf/FSharp.Editor.pt-BR.xlf
index 6c9a2e0bda9..cc9abde1f4c 100644
--- a/xlf/FSharp.Editor.pt-BR.xlf
+++ b/xlf/FSharp.Editor.pt-BR.xlf
@@ -7,6 +7,11 @@
         <target state="translated">Adicionar a palavra-chave 'new'</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConvertToSingleEqualsEqualityExpression">
+        <source>Use '=' for equality check</source>
+        <target state="new">Use '=' for equality check</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ChangePrefixNegationToInfixSubtraction">
         <source>Use subtraction instead of negation</source>
         <target state="new">Use subtraction instead of negation</target>
diff --git a/xlf/FSharp.Editor.ru.xlf b/xlf/FSharp.Editor.ru.xlf
index 5b061944686..4aea41af1e0 100644
--- a/xlf/FSharp.Editor.ru.xlf
+++ b/xlf/FSharp.Editor.ru.xlf
@@ -7,6 +7,11 @@
         <target state="translated">Добавить ключевое слово "new"</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConvertToSingleEqualsEqualityExpression">
+        <source>Use '=' for equality check</source>
+        <target state="new">Use '=' for equality check</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ChangePrefixNegationToInfixSubtraction">
         <source>Use subtraction instead of negation</source>
         <target state="new">Use subtraction instead of negation</target>
diff --git a/xlf/FSharp.Editor.tr.xlf b/xlf/FSharp.Editor.tr.xlf
index 7266f9c201e..a34f26a5e29 100644
--- a/xlf/FSharp.Editor.tr.xlf
+++ b/xlf/FSharp.Editor.tr.xlf
@@ -7,6 +7,11 @@
         <target state="translated">'new' anahtar sözcüğünü ekleme</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConvertToSingleEqualsEqualityExpression">
+        <source>Use '=' for equality check</source>
+        <target state="new">Use '=' for equality check</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ChangePrefixNegationToInfixSubtraction">
         <source>Use subtraction instead of negation</source>
         <target state="new">Use subtraction instead of negation</target>
diff --git a/xlf/FSharp.Editor.zh-Hans.xlf b/xlf/FSharp.Editor.zh-Hans.xlf
index af1ab1fd54c..a9259adff01 100644
--- a/xlf/FSharp.Editor.zh-Hans.xlf
+++ b/xlf/FSharp.Editor.zh-Hans.xlf
@@ -7,6 +7,11 @@
         <target state="translated">添加“新”关键字</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConvertToSingleEqualsEqualityExpression">
+        <source>Use '=' for equality check</source>
+        <target state="new">Use '=' for equality check</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ChangePrefixNegationToInfixSubtraction">
         <source>Use subtraction instead of negation</source>
         <target state="new">Use subtraction instead of negation</target>
diff --git a/xlf/FSharp.Editor.zh-Hant.xlf b/xlf/FSharp.Editor.zh-Hant.xlf
index abf9dcb7465..4d66d55af16 100644
--- a/xlf/FSharp.Editor.zh-Hant.xlf
+++ b/xlf/FSharp.Editor.zh-Hant.xlf
@@ -7,6 +7,11 @@
         <target state="translated">新增 'new' 關鍵字</target>
         <note />
       </trans-unit>
+      <trans-unit id="ConvertToSingleEqualsEqualityExpression">
+        <source>Use '=' for equality check</source>
+        <target state="new">Use '=' for equality check</target>
+        <note />
+      </trans-unit>
       <trans-unit id="ChangePrefixNegationToInfixSubtraction">
         <source>Use subtraction instead of negation</source>
         <target state="new">Use subtraction instead of negation</target>