Call into libjli.dylib instead of libjvm.dylib to fix legacy Java SE 6 popup on OSX #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6 popup on OSX If you don't have the legacy Java6 installed then the call to JNI_CreateJavaVM() will result in a popup requesting you to install it and abort, even if you call the libjvm.dylib that's included as part of JDK8. According to jpype-project/jpype#160 and https://bugs.openjdk.java.net/browse/JDK-7131356 this is a Java8 bug and the recommended fix is to call into libjli.dylib instead. Indeed this fixes the issue and the popup no longer shows up.
Redth
pushed a commit
to Redth/java.interop
that referenced
this pull request
Oct 26, 2017
dotnet#198) If you don't have the legacy Java 6 installed on macOS, then calling `JNI_CreateJavaVM()` will result in a popup requesting you to install the legacy Java 6 VM then abort, *even if* you call the `libjvm.dylib` that's included as part of JDK8: **To open "this Java application" you need to install the legacy Java SE 6 runtime.** Click "More Info..." to visit the legacy Java SE 6 download website. [More Info...] [OK] This is due to a [Java 8 bug][jdk7131356], and a [suggested solution][jdkfix] is to instead use `libjli.dylib`. [jdk7131356]: https://bugs.openjdk.java.net/browse/JDK-7131356 [jdkfix]: jpype-project/jpype#160 Update `JdkInfo.props` so that `$(JdkJvmPath)` uses `libjli.dylib` instead of `libjvm.dylib`, removing the above warning dialog.
4 tasks
This was referenced Apr 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you don't have the legacy Java6 installed then the call to JNI_CreateJavaVM() will result in a popup requesting you to install it and abort, even if you call the libjvm.dylib that's included as part of JDK8.
According to jpype-project/jpype#160 and https://bugs.openjdk.java.net/browse/JDK-7131356 this is a Java8 bug and the recommended fix is to call into libjli.dylib instead.
Indeed this fixes the issue and the popup no longer shows up.