-
Notifications
You must be signed in to change notification settings - Fork 505
Added support for reduced accuracy detection on iOS 14 #1739
Added support for reduced accuracy detection on iOS 14 #1739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think beyond my feedback seems fine. XML docs need to be updated, but besides that is good.
@jamesmontemagno I've adjusted the version check to use the DeviceInfo API as suggested |
@jamesmontemagno The suggested changes have been applied |
Co-authored-by: James Montemagno <[email protected]>
e6776a7
to
96b69b4
Compare
Not sure if we should still pull this in for Xamarin.Essentials since it's adding APIs but at the same time it also supports newer iOS functionalities. THoughts @jamesmontemagno ? |
I'm relatively fine with it if we do a 1.8.0 |
@jamesmontemagno @jfversluis |
@mina5500 this is not merged, so unfortunately not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this exact code is running in .NET MAUI without too many problems and we have updated Xamarin.Essentials with another major version, so let's do it.
Description of Change
iOS 14 added the ability for users to grant location permission with reduced accuracy.
In such cases the requested accuracy is ignored and the coarse location is returned.
This PR adds:
Platform notes:
ReducedAccuracy
property always returns false on non-iOS platformsNSLocationTemporaryUsageDescriptionDictionary
in the app's plist file. The keyXamarinEssentialsFullAccuracyUsageDescription
was used for this purpose.Bugs Fixed
API Changes
Added:
bool Location.ReducedAccuracy { get; set; }
bool GeolocationRequest.RequestFullAccuracy { get; set; }
PR Checklist
main
at time of PR