diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md index e741c1570..d8dc9b817 100644 --- a/.github/ISSUE_TEMPLATE/feature-request.md +++ b/.github/ISSUE_TEMPLATE/feature-request.md @@ -6,22 +6,4 @@ labels: feature-request assignees: '' --- - -## Summary -Please provide a brief summary of your proposal. Two to three sentences is best here. - -## API Changes - -Include a list of all API changes, additions, subtractions as would be required by your proposal. These APIs should be considered placeholders, so the naming is not as important as getting the concepts correct. If possible you should include some "example" code of usage of your new API. You should also provide details of the level of availability for the feature on each of the supported platforms. - -e.g. - -In order to facilitate the new Shiny Button api, a bool is added to the Button class. This is done as a bool because it is simpler to data bind and other reasons... - - var button = new Button (); - button.MakeShiny = true; // new API - -The MakeShiny API works even if the button is already visible. - -## Intended Use Case -Provide a detailed example of where your proposal would be used and for what purpose. \ No newline at end of file +We are no longer accepting new feature request for Xamarin.Essentials. Please make your new feature requests in the .NET MAUI repo which contains .NET MAUI Essentials. diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index c918f7b74..bc46302e5 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,3 +1,20 @@ + + ### Description of Change ### Describe your changes here. diff --git a/DeviceTests/DeviceTests.Android/DeviceTests.Android.csproj b/DeviceTests/DeviceTests.Android/DeviceTests.Android.csproj index 0240f5a08..ec88c04ec 100644 --- a/DeviceTests/DeviceTests.Android/DeviceTests.Android.csproj +++ b/DeviceTests/DeviceTests.Android/DeviceTests.Android.csproj @@ -9,7 +9,6 @@ DeviceTests.Droid XamarinEssentialsDeviceTestsAndroid v10.0 - false True true Resource @@ -19,6 +18,7 @@ true true Xamarin.Android.Net.AndroidClientHandler + armeabi-v7a;x86;x86_64;arm64-v8a true @@ -29,7 +29,6 @@ prompt 4 None - armeabi-v7a;x86;x86_64;arm64-v8a 1G false false @@ -47,7 +46,6 @@ 4 true false - armeabi-v7a;x86;x86_64;arm64-v8a true 1G @@ -59,12 +57,13 @@ - + - - + + + diff --git a/DeviceTests/DeviceTests.Android/Properties/AndroidManifest.xml b/DeviceTests/DeviceTests.Android/Properties/AndroidManifest.xml index 4ab740cad..7d1546089 100644 --- a/DeviceTests/DeviceTests.Android/Properties/AndroidManifest.xml +++ b/DeviceTests/DeviceTests.Android/Properties/AndroidManifest.xml @@ -12,5 +12,36 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/DeviceTests/DeviceTests.Shared/DeviceTests.Shared.csproj b/DeviceTests/DeviceTests.Shared/DeviceTests.Shared.csproj index 8e6758173..903c8db25 100644 --- a/DeviceTests/DeviceTests.Shared/DeviceTests.Shared.csproj +++ b/DeviceTests/DeviceTests.Shared/DeviceTests.Shared.csproj @@ -1,7 +1,7 @@ - + - Xamarin.iOS10;MonoAndroid90;uap10.0.16299 - Xamarin.iOS10;MonoAndroid90; + Xamarin.iOS10;MonoAndroid10.0;uap10.0.16299 + Xamarin.iOS10;MonoAndroid10.0; XamarinEssentialsDeviceTestsShared DeviceTests.Shared $(AssemblyName) ($(TargetFramework)) @@ -23,7 +23,7 @@ - + @@ -37,14 +37,6 @@ - - - - - - - - diff --git a/DeviceTests/DeviceTests.Shared/Geocoding_Tests.cs b/DeviceTests/DeviceTests.Shared/Geocoding_Tests.cs index 771612655..ef2dac7f2 100644 --- a/DeviceTests/DeviceTests.Shared/Geocoding_Tests.cs +++ b/DeviceTests/DeviceTests.Shared/Geocoding_Tests.cs @@ -48,7 +48,7 @@ public async Task Get_Placemarks_Location(double latitude, double longitude) } [Theory] - [InlineData("Microsoft Building 25 Redmond WA USA")] + [InlineData("Redmond, WA, USA")] public async Task Get_Locations(string address) { try diff --git a/DeviceTests/DeviceTests.UWP/DeviceTests.UWP.csproj b/DeviceTests/DeviceTests.UWP/DeviceTests.UWP.csproj index 9e1398bf9..3ace48502 100644 --- a/DeviceTests/DeviceTests.UWP/DeviceTests.UWP.csproj +++ b/DeviceTests/DeviceTests.UWP/DeviceTests.UWP.csproj @@ -114,7 +114,7 @@ - + diff --git a/DeviceTests/DeviceTests.iOS/DeviceTests.iOS.csproj b/DeviceTests/DeviceTests.iOS/DeviceTests.iOS.csproj index b340089a1..cedc68a32 100644 --- a/DeviceTests/DeviceTests.iOS/DeviceTests.iOS.csproj +++ b/DeviceTests/DeviceTests.iOS/DeviceTests.iOS.csproj @@ -77,10 +77,10 @@ - + - + diff --git a/DeviceTests/DeviceTests.iOS/Main.cs b/DeviceTests/DeviceTests.iOS/Main.cs index c79e23b40..82ad09057 100644 --- a/DeviceTests/DeviceTests.iOS/Main.cs +++ b/DeviceTests/DeviceTests.iOS/Main.cs @@ -1,4 +1,5 @@ -using UIKit; +using System; +using UIKit; namespace DeviceTests.iOS { @@ -6,10 +7,10 @@ public class Application { static void Main(string[] args) { - if (args?.Length > 0) // usually means this is from xharness - UIApplication.Main(args, null, nameof(TestApplicationDelegate)); + if (!string.IsNullOrWhiteSpace(Environment.GetEnvironmentVariable("ci-run"))) + UIApplication.Main(args, null, typeof(TestApplicationDelegate)); else - UIApplication.Main(args, null, nameof(AppDelegate)); + UIApplication.Main(args, null, typeof(AppDelegate)); } } } diff --git a/DeviceTests/build.cake b/DeviceTests/build.cake index 4bea8f8b0..69aa1586b 100644 --- a/DeviceTests/build.cake +++ b/DeviceTests/build.cake @@ -41,6 +41,7 @@ System.Environment.SetEnvironmentVariable("PATH", $"{ANDROID_HOME}/emulator" + System.IO.Path.PathSeparator + EnvironmentVariable("PATH")); +var RESTORE_CONFIG = MakeAbsolute((FilePath)"../devopsnuget.config").FullPath; // utils @@ -99,6 +100,7 @@ Task("build-ios") c.Properties["Platform"] = new List { "iPhoneSimulator" }; c.Properties["BuildIpa"] = new List { "true" }; c.Properties["ContinuousIntegrationBuild"] = new List { "false" }; + c.Properties["RestoreConfigFile"] = new List { RESTORE_CONFIG }; c.Targets.Clear(); c.Targets.Add("Rebuild"); c.BinaryLogger = new MSBuildBinaryLogSettings { @@ -116,11 +118,12 @@ Task("test-ios-emu") CleanDirectories(IOS_TEST_RESULTS_PATH.FullPath); // Run the tests - var resultCode = StartProcess("xharness", "ios test " + + var resultCode = StartProcess("xharness", "apple test " + $"--app=\"{IOS_IPA_PATH}\" " + $"--targets=\"ios-simulator-64\" " + $"--output-directory=\"{IOS_TEST_RESULTS_PATH}\" " + - $"--verbosity=\"Debug\" "); + $"--verbosity=\"Debug\" " + + $"--set-env=ci-run=true "); // Rename test result files var resultFiles = GetFiles($"{IOS_TEST_RESULTS_PATH}/*.xml"); @@ -142,6 +145,7 @@ Task("build-android") c.Configuration = "Debug"; // needs to be debug so unit tests get discovered c.Restore = true; c.Properties["ContinuousIntegrationBuild"] = new List { "false" }; + c.Properties["RestoreConfigFile"] = new List { RESTORE_CONFIG }; c.Targets.Clear(); c.Targets.Add("Rebuild"); c.Targets.Add("SignAndroidPackage"); @@ -221,6 +225,7 @@ Task("build-uwp") c.Properties["AppxBundlePlatforms"] = new List { "x86" }; c.Properties["AppxBundle"] = new List { "Always" }; c.Properties["AppxPackageSigningEnabled"] = new List { "true" }; + c.Properties["RestoreConfigFile"] = new List { RESTORE_CONFIG }; c.Targets.Clear(); c.Targets.Add("Rebuild"); c.BinaryLogger = new MSBuildBinaryLogSettings { diff --git a/README.md b/README.md index c5a3e24f6..c0dc98d5a 100644 --- a/README.md +++ b/README.md @@ -77,3 +77,5 @@ Here are some frequently asked questions about Xamarin.Essentials, but be sure t Please see the [License](LICENSE). +## Stats + diff --git a/Samples/Samples.Android/Samples.Android.csproj b/Samples/Samples.Android/Samples.Android.csproj index d373ef946..96bcf008a 100644 --- a/Samples/Samples.Android/Samples.Android.csproj +++ b/Samples/Samples.Android/Samples.Android.csproj @@ -58,11 +58,9 @@ - - + + - - diff --git a/Samples/Samples.Mac/Samples.Mac.csproj b/Samples/Samples.Mac/Samples.Mac.csproj index c8ce05423..15c88faeb 100644 --- a/Samples/Samples.Mac/Samples.Mac.csproj +++ b/Samples/Samples.Mac/Samples.Mac.csproj @@ -61,8 +61,8 @@ - - + + diff --git a/Samples/Samples.UWP/Samples.UWP.csproj b/Samples/Samples.UWP/Samples.UWP.csproj index fb0afd793..1f47c7941 100644 --- a/Samples/Samples.UWP/Samples.UWP.csproj +++ b/Samples/Samples.UWP/Samples.UWP.csproj @@ -119,8 +119,8 @@ - - + + diff --git a/Samples/Samples.iOS/Main.cs b/Samples/Samples.iOS/Main.cs index 0bb5eadad..5ece82925 100644 --- a/Samples/Samples.iOS/Main.cs +++ b/Samples/Samples.iOS/Main.cs @@ -6,7 +6,7 @@ public class Application { static void Main(string[] args) { - UIApplication.Main(args, null, nameof(AppDelegate)); + UIApplication.Main(args, null, typeof(AppDelegate)); } } } diff --git a/Samples/Samples.iOS/Samples.iOS.csproj b/Samples/Samples.iOS/Samples.iOS.csproj index c17c6cd67..03f794e05 100644 --- a/Samples/Samples.iOS/Samples.iOS.csproj +++ b/Samples/Samples.iOS/Samples.iOS.csproj @@ -80,8 +80,8 @@ - - + + diff --git a/Samples/Samples/App.xaml b/Samples/Samples/App.xaml index 69b065d88..c5348dff4 100644 --- a/Samples/Samples/App.xaml +++ b/Samples/Samples/App.xaml @@ -10,6 +10,21 @@ + + + + + \ No newline at end of file diff --git a/Samples/Samples/Samples.csproj b/Samples/Samples/Samples.csproj index bd5450509..f85919620 100644 --- a/Samples/Samples/Samples.csproj +++ b/Samples/Samples/Samples.csproj @@ -15,8 +15,8 @@ - - + + diff --git a/Samples/Samples/View/DeviceInfoPage.xaml b/Samples/Samples/View/DeviceInfoPage.xaml index a7ca78225..af212e140 100644 --- a/Samples/Samples/View/DeviceInfoPage.xaml +++ b/Samples/Samples/View/DeviceInfoPage.xaml @@ -29,6 +29,7 @@