BugFix: Async Column Styles #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VGT was using
setTimeoutto apply styles for fixed headers. This is now covered by watchers detecting when the styling changes need to be re-applied.setTimeoutinsetColumnStylesto fix async testing issues.When testing in Jest the snapshots sometimes render like:
This occurred due to the
setTimeoutoccasionally finishing before the snapshot fired. This can be fixed at the test level by using Jest'sfakeTimers. This approach works in some cases, however it adds complexity and does not work with Vue-Test-Utils in all scenarios.