Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search does not work with escaped characters #466

Closed
1 task done
karakayasemi opened this issue Nov 21, 2018 · 5 comments
Closed
1 task done

Search does not work with escaped characters #466

karakayasemi opened this issue Nov 21, 2018 · 5 comments
Labels

Comments

@karakayasemi
Copy link

karakayasemi commented Nov 21, 2018

Since only search term is escaped in this method https://github.com/xaksis/vue-good-table/blob/master/src/components/types/default.js#L9, search does not work with escaped characters. As a quick solution, we may escape rowVal too.

Issue Type

  • Bug

Specs

2.16.0

What browser?
Chrome, Firefox

Expected Behavior

"192.168" search term should match with all entries in provided fiddle.

Actual Behavior

Nothing matched

jsfiddle

(https://jsfiddle.net/4L27s8cy/

@xaksis xaksis added the bug label Nov 27, 2018
@karakayasemi
Copy link
Author

karakayasemi commented Nov 27, 2018

@xaksis why input needs to be escaped from special characters when searching? Can we simply remove the escaping part? IMHO, the other simple option escaping rowval too.

@xaksis
Copy link
Owner

xaksis commented Nov 27, 2018

@karakayasemi the diactric library crashes if the characters like '[' aren't escaped. I'll explore the latter option for fixing this.

@karakayasemi
Copy link
Author

Alright, what about escaping rowval too?

@karakayasemi
Copy link
Author

@xaksis Have you had time for the problem?

@xaksis xaksis closed this as completed in d35fb20 Mar 3, 2019
@xaksis
Copy link
Owner

xaksis commented Mar 3, 2019

@karakayasemi really sorry for the delay on this... this should now be fixed with v2.16.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants