Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection TCP reset during grace-time-check crashes program #33

Open
agibson2 opened this issue Jul 9, 2024 · 1 comment
Open

Connection TCP reset during grace-time-check crashes program #33

agibson2 opened this issue Jul 9, 2024 · 1 comment

Comments

@agibson2
Copy link
Contributor

agibson2 commented Jul 9, 2024

While waiting with the connection open during the grace-time-check, If a connection is reset by the server or by some other network device between the systems, the program crashes and doesn't display any results. I created a patch for it and made a small addition to catch the ConnectionResetError and changed the text to say Session was reset instead of Session was closed. I left it as being vulnerable in my change. Maybe creating a new category for network errors and put a new report section for those might be the best idea instead of leaving it in the vulnerable category, but since I am aware of what it means, I just left it.

The changes are here...
If you want this change, I can submit a pull request for it.

main...agibson2:CVE-2024-6387_Check:main

@xaitax
Copy link
Owner

xaitax commented Jul 19, 2024

Hi @agibson2

yes, that would be great, thank you!
And sorry for the delay - vacation time. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants