Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge test-including default-template #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

inaimathi
Copy link
Contributor

This is a more elaborate default-template that

  1. Includes separate src and test directories
  2. Includes a shell script that runs the test suite in sbcl
  3. Includes a .travis.yml file that allows the project to be trivially built in CI

I'm mainly submitting this because of inaimathi/house@262ceba#r45065608 (which tells me that it might be a good idea in general to standardize project structure because there are non-obvious ways to mess it up).

The points of contention I can see are related to the default choices (Should we use prove? Should we use travis? Should we assume sbcl?).

Overall:

  1. The defaults can be overriden as always (that was the point of the default-template addition :p)
  2. encouraging and simplifying testing/CI is worth picking reasonable but somewhat arbitrary defaults
  3. A plurality of the CL community seems to use sbcl in any case

#!/bin/bash
sbcl \
--eval '(ql:quickload (list :(#| TMPL_VAR name |#) :(#| TMPL_VAR name |#)/test))' \
--eval '(or (and (prove:run :(#| TMPL_VAR name |#)/test) (uiop:quit 0)) (uiop:quit -1))'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a specific runner. Maybe it could be another template directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants