Make DockRegistry UUPS upgradeable
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
V1d0r
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per
DockRegistryimplementation PR #18, we need to consider the ability to enhance the registry capabilities in the future.Right now,
DockRegistryis responsible for creating multiple docks and orchestratingContainers deployment. In addition, it is also in charge of allowing either the dock orContainerowner to transfer their ownership to another address (be it EOA or multisig).Apart from this, since all
Containers must do an external call to theDockRegistryto get the current owner (due to theonlyOwnermodifier - see this, we've decided to also store the address of theModuleKeeperinside it. This allows theDockRegistryto truly act as the single source of truth in the MetaDock ecosystem.With this in mind, we should prepare for any other management contract that might be implemented in the future and must be orchestrated through the
DockRegistry. Therefore, we've decided to make the registry upgradeable through the UUPS proxy pattern. By using this approach, we have the ability to renounce the upgradeability at any point in time due to the UUPS nature (when the protocol is stable and no more extra core features might be added).task: 28994cdf30964c90b34f17d7869ed085