Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frequency weights to design.variables #28

Closed
ayushpatnaikgit opened this issue Aug 3, 2022 · 2 comments
Closed

Add frequency weights to design.variables #28

ayushpatnaikgit opened this issue Aug 3, 2022 · 2 comments

Comments

@ayushpatnaikgit
Copy link
Member

Since many functions require frequency weights, we can store it in design.variables rather than having each function derive it from probs.

Instead of probs, perhaps, we should call it probability_weights_reserved? Similarly, frequency_weights_reserved.

The reason we're only storing probability weights is that we didn't anticipate so many Julia functions to use frequency weights. I believe the survey package in R only store probability weights, and most R functions use probability weights.

Note, we want the information about weights to be in the same data frame and not make it a property of svydesign because of performance reasons. combine function in DataFrames works a lot faster.

@iuliadmtru
Copy link
Contributor

I fixed this with PR #32, although the discussion should remain open regarding the names of the fields.

@ayushpatnaikgit
Copy link
Member Author

I will discuss this with @chiraganand on phone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants